Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all mods to dbm 2.2.0 with discord.js v14 (And deletions) #986

Open
wants to merge 70 commits into
base: beta_branch_2.2
Choose a base branch
from
Open

Upgrade all mods to dbm 2.2.0 with discord.js v14 (And deletions) #986

wants to merge 70 commits into from

Conversation

TheMonDon
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Merging all my changes I made for DBM 2.2.0 which will have discord.js v14. Removed mods talked over with staff.

Big changes:
fixed to when needed.
version updated from 2.1.7 to 2.2.0
Lots of HTML updates/fixes

Status

  • Code changes have been tested against the Discord API and the discord.js wrapper, or there are no code changes
  • Documentation has been added/modified, or there is nothing to change (docs/mods.json)

Semantic versioning classification:

  • This PR changes DBM's interface (methods or parameters added to default methods)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

TheMonDon added 30 commits June 1, 2023 22:15
@TheMonDon
Initial commit - Change version to 2.2.0
767138a
@TheMonDon
Update image attachments
e82b047
@TheMonDon
create/edit to object and BitField suffix
368b67f
@TheMonDon
.deleted has been deleted, avatar change, missed init
2909e59
@TheMonDon
Merge branch 'dbm-network:master' into DBM-2.2.0
5b02046
@TheMonDon
Update create_permission_MOD.js
65bff86
@TheMonDon
Merge branch 'DBM-2.2.0' of https://github.com/TheMonDon/mods into DB…
8b1f520 
…M-2.2.0
@TheMonDon
Fix data
7b89ef3
@TheMonDon
Remove forum channel MOD, update clone channel
96700d2
@TheMonDon
Merge branch 'dbm-network:master' into DBM-2.2.0
5dbe180
@TheMonDon
add try...catch to control music
5c61b55
@TheMonDon
Fix color inputs inside html
703b61e
@TheMonDon
Start updating music to v14
fd5d2b9
@TheMonDon
Remove Anchor Actions (Now default)
d8fb713
@TheMonDon
A lot of music for v14 fixes/updates
2c2a8c7
@TheMonDon
Replace store-in-variable with retrieve-from-variable
802e425 
Last time I did not know if these were different, SRD confirmed they are different.
@TheMonDon
html fixes, check if member fix, music fix & new music actions
f8135a1
@TheMonDon
Force rgb-hex to use 3.0.0
af9647f
@TheMonDon
Music Updates/Fixes
0e2ea2e
@TheMonDon
Music Action Updates
a3b9393
@TheMonDon
Remove forum channel mod: new default action
7223e0b
@TheMonDon
Minor code changes
db77a7d
@TheMonDon
Mod Section Changes
dd38249
@TheMonDon
Section changes & minor code changes
2a3fae9
@TheMonDon
Action HTML Fixes
0ab73b8
@TheMonDon
More HTML changes
c5412db
@TheMonDon
Remove basic math operation
ab6e9bb
@TheMonDon
Fix store queue info
0b09273
@TheMonDon
More HTML Fixes/Changes
955b141
@TheMonDon
Update mods.json
d675b7d
OneAndOnlyFinbar
OneAndOnlyFinbar requested changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@OneAndOnlyFinbar OneAndOnlyFinbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove following from docs/mods.json

actions/anchor_create_MOD.js
actions/anchor_jump_MOD.js
actions/attach_image_to_embed_MOD.js
actions/create_forum_channel_MOD.js

actions/check_if_member_MOD.js Show resolved Hide resolved
actions/play_music_MOD.js Outdated Show resolved Hide resolved
@TheMonDon TheMonDon changed the base branch from v2.2.0 to master July 24, 2023 23:11
DetroitWhiskey136
DetroitWhiskey136 reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@DetroitWhiskey136 DetroitWhiskey136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the couple things i pointed out, this all looks up to par by my untrained eye.

@TheMonDon TheMonDon requested review from OneAndOnlyFinbar and DetroitWhiskey136 and removed request for almeidx October 20, 2023 22:50
DetroitWhiskey136
DetroitWhiskey136 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@DetroitWhiskey136 DetroitWhiskey136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@DetroitWhiskey136
Copy link
Contributor

now you just have to get Finbar to resolve that change request.

@DetroitWhiskey136
Copy link
Contributor

and change the branch

@TheMonDon TheMonDon changed the base branch from master to beta_branch_2.2 October 21, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneAndOnlyFinbar OneAndOnlyFinbar OneAndOnlyFinbar approved these changes

@DetroitWhiskey136 DetroitWhiskey136 DetroitWhiskey136 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheMonDon @DetroitWhiskey136 @OneAndOnlyFinbar