Update: adjusted MLA vessel form to account for reissued applications

dbca-wa · Jan 24, 2025 · 682c7f3 · 682c7f3
1 parent a5819a0
commit 682c7f3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/mooringlicensing/components/proposals/serializers.py b/mooringlicensing/components/proposals/serializers.py
@@ -30,7 +30,7 @@
     InsuranceCertificateDocument,
 )
 from mooringlicensing.ledger_api_utils import retrieve_email_userro
-from mooringlicensing.components.approvals.models import MooringLicence, MooringOnApproval, Approval
+from mooringlicensing.components.approvals.models import MooringLicence, MooringOnApproval, Approval, VesselOwnershipOnApproval
 from mooringlicensing.components.main.serializers import CommunicationLogEntrySerializer
 from mooringlicensing.components.users.serializers import UserSerializer, ProposalApplicantSerializer
 from ledger_api_client.managed_models import SystemUser
@@ -302,6 +302,11 @@ def get_current_vessels_rego_list(self, obj):
         if obj.approval and type(obj.approval.child_obj) is MooringLicence:
             vessels_str = ''
             vessels_str += ', '.join([vo.vessel.rego_no for vo in obj.listed_vessels.filter(end_date__isnull=True)])
+
+            if not vessels_str and obj.approval and obj.approval.reissued:
+                voas = VesselOwnershipOnApproval.objects.filter(approval=obj.approval,end_date__isnull=True).distinct("vessel_ownership__vessel__rego_no")
+                vessels_str += ', '.join([voa.vessel_ownership.vessel.rego_no for voa in voas])
+
             return vessels_str
 
     def get_previous_application_preferred_bay_id(self, obj):
@@ -1097,6 +1102,11 @@ def get_current_vessels_rego_list(self, obj):
         if obj.approval and type(obj.approval.child_obj) is MooringLicence:
             vessels_str = ''
             vessels_str += ', '.join([vo.vessel.rego_no for vo in obj.listed_vessels.filter(end_date__isnull=True)])
+
+            if not vessels_str and obj.approval and obj.approval.reissued:
+                voas = VesselOwnershipOnApproval.objects.filter(approval=obj.approval,end_date__isnull=True).distinct("vessel_ownership__vessel__rego_no")
+                vessels_str += ', '.join([voa.vessel_ownership.vessel.rego_no for voa in voas])
+
             return vessels_str
 
     def get_reissued(self, obj):

diff --git a/mooringlicensing/frontend/mooringlicensing/src/components/common/vessels.vue b/mooringlicensing/frontend/mooringlicensing/src/components/common/vessels.vue
@@ -17,7 +17,7 @@
                         v-model="vessel.vessel_details.vessel_name" required />
                 </div>
             </div>
-            <div v-if="!readonly || vessel.vessel_ownership.individual_owner" class="row form-group">
+            <div v-if="!readonly || (vessel.vessel_ownership.individual_owner && vessel.vessel_ownership.owner_name)" class="row form-group">
                 <label for="" class="col-sm-3 control-label">Registration vessel owner *</label>
                 <div v-if="!readonly" class="col-sm-9">
                     <div class="row">

diff --git a/mooringlicensing/frontend/mooringlicensing/src/components/form_mla.vue b/mooringlicensing/frontend/mooringlicensing/src/components/form_mla.vue
@@ -208,7 +208,7 @@
             },
             readonlyMLA: function() {
                 let readonly = false;
-                if (this.readonly || (this.proposal.proposal_type.code === 'new')) {
+                if (this.readonly || (this.proposal.proposal_type.code === 'new' && !this.proposal.reissued)) {
                     readonly = true;
                 }
                 return readonly;