Skip to content

Commit

Permalink
Fix encoded URLs in existing UrlBuilder tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Jason Eberle committed Mar 2, 2018
1 parent ef04a7c commit 9afa270
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/Imgix/Tests/UrlBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,15 @@ public function testWithFullyQualifiedUrlWithSpaces() {
$builder->setSignKey("test1234");
$url = $builder->createUrl("https://my-demo-site.com/files/133467012/avatar icon.png");

$this->assertEquals("https://demos.imgix.net/https%3A%2F%2Fmy-demo-site.com%2Ffiles%2F133467012%2Favatar+icon.png?s=1f65f21dab7da2d3c104dfaf898ce8cc", $url);
$this->assertEquals("https://demos.imgix.net/https%3A%2F%2Fmy-demo-site.com%2Ffiles%2F133467012%2Favatar%20icon.png?s=6a1d47f292194cfa7573da0e2bb6b0f4", $url);
}

public function testWithFullyQualifiedUrlWithParams() {
$builder = new UrlBuilder("demos.imgix.net", true, "", ShardStrategy::CRC, false);
$builder->setSignKey("test1234");
$url = $builder->createUrl("https://my-demo-site.com/files/133467012/avatar icon.png?some=chill&params=1");

$this->assertEquals("https://demos.imgix.net/https%3A%2F%2Fmy-demo-site.com%2Ffiles%2F133467012%2Favatar+icon.png%3Fsome%3Dchill%26params%3D1?s=970429e4d150c4609142f4c0a86089c9", $url);
$this->assertEquals("https://demos.imgix.net/https%3A%2F%2Fmy-demo-site.com%2Ffiles%2F133467012%2Favatar%20icon.png%3Fsome%3Dchill%26params%3D1?s=bbc73c61ebc739337b852ff8423a1da9", $url);
}

public function testInclusionOfLibraryVersionParam() {
Expand All @@ -124,7 +124,7 @@ public function testInclusionOfLibraryVersionParam() {
$composerFileJson = json_decode(file_get_contents("./composer.json"), true);
$version = $composerFileJson['version'];

$this->assertEquals("https://demos.imgix.net/https%3A%2F%2Fmy-demo-site.com%2Ffiles%2F133467012%2Favatar+icon.png%3Fsome%3Dchill%26params%3D1?ixlib=php-" . $version, $url);
$this->assertEquals("https://demos.imgix.net/https%3A%2F%2Fmy-demo-site.com%2Ffiles%2F133467012%2Favatar%20icon.png%3Fsome%3Dchill%26params%3D1?ixlib=php-" . $version, $url);
}
}
?>

0 comments on commit 9afa270

Please sign in to comment.