-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Add RTL case for slide gaps via CSS in docs #786
Conversation
Note: formatting that file via prettier kept adding an extra backtick as seen on line 50 |
@zaaakher nice to have you back 🙂. Thanks for the contribution. I will review as soon as I get a chance. Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks as always for making this library better and easier to use 👍🏻.
Please see my minor comment and after fixing that I’m ready to merge this.
packages/embla-carousel-docs/src/content/pages/guides/slide-gaps.md
Outdated
Show resolved
Hide resolved
packages/embla-carousel-docs/src/content/pages/guides/slide-gaps.md
Outdated
Show resolved
Hide resolved
I made the changes of this PR "blindfolded" (without running the docs gatsby app due to #662). So my apologies for missing tiny things here or there 😅 |
@zaaakher no worries. I’m thankful that you continuously want to make this library better! Thanks for the fixes. I’m ready to merge this as soon as I’ve squashed the commits 🎉. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work ✨!
You're welcome brother, it's my absolute pleasure. 🌹 |
Co-authored-by: David <[email protected]>
c5db1f4
to
89b9183
Compare
Released in v8.0.1. |
Hi @davidjerleke,
Hope you're doing well.
This PR is a simple addition to the slide-gaps section of the docs to mention the RTL case.
Let me know If I missed something
Best,
Zakher