Skip to content

Commit

Permalink
Improve performance when finding snap targets.
Browse files Browse the repository at this point in the history
  • Loading branch information
davidjerleke committed Feb 28, 2024
1 parent 6a7afaa commit af396b2
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions packages/embla-carousel/src/components/ScrollTarget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ export function ScrollTarget(
function findTargetSnap(target: number): TargetType {
const distance = loop ? removeOffset(target) : constrain(target)
const ascDiffsToSnaps = scrollSnaps
.map((scrollSnap) => scrollSnap - distance)
.map((diffToSnap) => shortcut(diffToSnap, 0))
.map((diff, i) => ({ diff, index: i }))
.map((snap, index) => ({ diff: shortcut(snap - distance, 0), index }))
.sort((d1, d2) => mathAbs(d1.diff) - mathAbs(d2.diff))

const { index } = ascDiffsToSnaps[0]
Expand Down

0 comments on commit af396b2

Please sign in to comment.