Use eslint for nuve (lynckia#1321)

davidguv · Nov 9, 2018 · e21c150 · e21c150
1 parent a7016fb
commit e21c150
Show file tree

Hide file tree

Showing 55 changed files with 2,298 additions and 2,235 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -1,5 +1,5 @@
-nuve/nuveClient/build
-nuve/nuveClient/dist
+nuve/nuveClient/build/**/*.js
+nuve/nuveClient/dist/**/*.js
 erizo_controller/erizoClient/**/*.js
 spine/**/*.js
 extras/basic_example/public/erizo.js

diff --git a/.jshintignore b/.jshintignore
diff --git a/.jshintrc b/.jshintrc
diff --git a/erizo_controller/erizoClient/extras/firefox-extension/bootstrap.js b/erizo_controller/erizoClient/extras/firefox-extension/bootstrap.js
@@ -10,7 +10,7 @@ var domainsUsed = ['*.dit.upm.es'];
 var addonDomains = [];
 var allowedDomains = 'media.getusermedia.screensharing.allowedDomains';
 
-function startup(data, reason) {  // jshint ignore:line
+function startup(data, reason) {
     if (reason === APP_STARTUP) {
         return;
     }
@@ -26,7 +26,7 @@ function startup(data, reason) {  // jshint ignore:line
     prefs.setCharPref(allowedDomains, values.join(','));
 }
 
-function shutdown(data, reason) {  // jshint ignore:line
+function shutdown(data, reason) {
     if (reason === APP_SHUTDOWN) {
         return;
     }
@@ -39,6 +39,6 @@ function shutdown(data, reason) {  // jshint ignore:line
     prefs.setCharPref(allowedDomains, values.join(','));
 }
 
-function install(data, reason) {}  // jshint ignore:line
+function install(data, reason) {}
 
-function uninstall(data, reason) {}  // jshint ignore:line
+function uninstall(data, reason) {}
diff --git a/erizo_controller/erizoController/erizoController.js b/erizo_controller/erizoController/erizoController.js
@@ -19,7 +19,6 @@ global.config.erizoController.publicIP = global.config.erizoController.publicIP
 global.config.erizoController.hostname = global.config.erizoController.hostname || '';
 global.config.erizoController.port = global.config.erizoController.port || 8080;
 global.config.erizoController.ssl = global.config.erizoController.ssl || false;
-// jshint ignore:start
 global.config.erizoController.ssl_key =
   global.config.erizoController.ssl_key || '../../cert/key.pem';
 global.config.erizoController.ssl_cert =
@@ -44,7 +43,6 @@ global.config.erizoController.allowSinglePC =
 global.config.erizoController.maxErizosUsedByRoom =
   global.config.erizoController.maxErizosUsedByRoom || 100;
 
-// jshint ignore:end
 global.config.erizoController.roles = global.config.erizoController.roles ||
   { presenter: { publish: true, subscribe: true, record: true },
     viewer: { subscribe: true },
@@ -123,8 +121,8 @@ if (global.config.erizoController.listen_ssl) {
   // eslint-disable-next-line global-require
   const fs = require('fs');
   const options = {
-    key: fs.readFileSync(config.erizoController.ssl_key).toString(), // jshint ignore:line
-    cert: fs.readFileSync(config.erizoController.ssl_cert).toString(), // jshint ignore:line
+    key: fs.readFileSync(config.erizoController.ssl_key).toString(),
+    cert: fs.readFileSync(config.erizoController.ssl_cert).toString(),
   };
   if (config.erizoController.sslCaCerts) {
     options.ca = [];
@@ -139,18 +137,18 @@ if (global.config.erizoController.listen_ssl) {
   server = http.createServer();
 }
 
-server.listen(global.config.erizoController.listen_port); // jshint ignore:line
+server.listen(global.config.erizoController.listen_port);
   // eslint-disable-next-line global-require, import/no-extraneous-dependencies
 const io = require('socket.io').listen(server, { log: false });
 
 io.set('transports', ['websocket']);
 
 const EXIT_ON_NUVE_CHECK_FAIL = global.config.erizoController.exitOnNuveCheckFail;
-const WARNING_N_ROOMS = global.config.erizoController.warning_n_rooms; // jshint ignore:line
-const LIMIT_N_ROOMS = global.config.erizoController.limit_n_rooms; // jshint ignore:line
+const WARNING_N_ROOMS = global.config.erizoController.warning_n_rooms;
+const LIMIT_N_ROOMS = global.config.erizoController.limit_n_rooms;
 
 const INTERVAL_TIME_KEEPALIVE =
-  global.config.erizoController.interval_time_keepAlive; // jshint ignore:line
+  global.config.erizoController.interval_time_keepAlive;
 
 const BINDED_INTERFACE_NAME = global.config.erizoController.networkInterface;
 

diff --git a/erizo_controller/erizoController/models/Client.js b/erizo_controller/erizoController/models/Client.js
@@ -152,8 +152,8 @@ class Client extends events.EventEmitter {
       let url = sdp;
       if (options.state === 'recording') {
         const recordingId = sdp;
-        if (global.config.erizoController.recording_path) {  // jshint ignore:line
-          url = `${global.config.erizoController.recording_path + recordingId}.mkv`; // jshint ignore:line
+        if (global.config.erizoController.recording_path) {
+          url = `${global.config.erizoController.recording_path + recordingId}.mkv`;
         } else {
           url = `/tmp/${recordingId}.mkv`;
         }
@@ -204,7 +204,7 @@ class Client extends events.EventEmitter {
                          `clientId: ${this.id}, ` +
                          `streamId: ${id}`);
 
-          if (global.config.erizoController.report.session_events) {  // jshint ignore:line
+          if (global.config.erizoController.report.session_events) {
             const timeStamp = new Date();
             this.room.amqper.broadcast('event', { room: this.room.id,
               user: this.id,
@@ -299,7 +299,7 @@ class Client extends events.EventEmitter {
                              `clientId: ${this.id}, ` +
                              `streamId: ${options.streamId}`);
             callback(true, signMess.erizoId);
-            if (global.config.erizoController.report.session_events) {  // jshint ignore:line
+            if (global.config.erizoController.report.session_events) {
               const timeStamp = new Date();
               this.room.amqper.broadcast('event', { room: this.room.id,
                 user: this.id,
@@ -353,8 +353,8 @@ class Client extends events.EventEmitter {
     const recordingId = Math.random() * 1000000000000000000;
     let url;
 
-    if (global.config.erizoController.recording_path) {  // jshint ignore:line
-      url = `${global.config.erizoController.recording_path + recordingId}.mkv`;  // jshint ignore:line
+    if (global.config.erizoController.recording_path) {
+      url = `${global.config.erizoController.recording_path + recordingId}.mkv`;
     } else {
       url = `/tmp/${recordingId}.mkv`;
     }
@@ -405,8 +405,8 @@ class Client extends events.EventEmitter {
     const recordingId = options.id;
     let url;
 
-    if (global.config.erizoController.recording_path) {  // jshint ignore:line
-      url = `${global.config.erizoController.recording_path + recordingId}.mkv`;  // jshint ignore:line
+    if (global.config.erizoController.recording_path) {
+      url = `${global.config.erizoController.recording_path + recordingId}.mkv`;
     } else {
       url = `/tmp/${recordingId}.mkv`;
     }
@@ -434,7 +434,7 @@ class Client extends events.EventEmitter {
       this.state = 'sleeping';
       if (!this.room.p2p) {
         this.room.controller.removePublisher(this.id, streamId, () => {
-          if (global.config.erizoController.report.session_events) {  // jshint ignore:line
+          if (global.config.erizoController.report.session_events) {
             const timeStamp = new Date();
             this.room.amqper.broadcast('event', { room: this.room.id,
               user: this.id,
@@ -481,7 +481,7 @@ class Client extends events.EventEmitter {
         callback(true);
       } else {
         this.room.controller.removeSubscriber(this.id, to, (result) => {
-          if (global.config.erizoController.report.session_events) {  // jshint ignore:line
+          if (global.config.erizoController.report.session_events) {
             const timeStamp = new Date();
             this.room.amqper.broadcast('event', { room: this.room.id,
               user: this.id,
@@ -527,7 +527,7 @@ class Client extends events.EventEmitter {
             if (!this.room.p2p) {
               log.info('message: Unpublishing stream, streamId:', streamId);
               this.room.controller.removePublisher(this.id, streamId);
-              if (global.config.erizoController.report.session_events) {  // jshint ignore:line
+              if (global.config.erizoController.report.session_events) {
                 this.room.amqper.broadcast('event', { room: this.room.id,
                   user: this.id,
                   type: 'unpublish',
@@ -541,7 +541,7 @@ class Client extends events.EventEmitter {
       });
 
       if (!this.room.p2p &&
-          global.config.erizoController.report.session_events) {  // jshint ignore:line
+          global.config.erizoController.report.session_events) {
         this.room.amqper.broadcast('event', { room: this.room.id,
           user: this.id,
           type: 'user_disconnection',

diff --git a/erizo_controller/erizoJS/models/Node.js b/erizo_controller/erizoJS/models/Node.js
@@ -66,7 +66,7 @@ class Node extends EventEmitter {
       monitorMinVideoBw(mediaStream, this._onMonitorMinVideoBWCallback.bind(this), this.clientId);
     }
 
-    if (global.config.erizoController.report.rtcp_stats) {  // jshint ignore:line
+    if (global.config.erizoController.report.rtcp_stats) {
       log.debug('message: RTCP Stat collection is active');
       mediaStream.getPeriodicStats((newStats) => {
         this.emit('periodic_stats', newStats);

diff --git a/erizo_controller/erizoJS/models/SessionDescription.js b/erizo_controller/erizoJS/models/SessionDescription.js
@@ -151,7 +151,6 @@ function getMediaInfoFromDescription(info, sdp, mediaType) {
     });
 
     if (isSimulcast) {
-      /* jshint camelcase: false */
       simulcast.setSimulcastPlainString(`${ridDirection} rid=${ridsData.join(';')}`);
       media.simulcast_03 = simulcast;
     }

diff --git a/erizo_controller/test/erizoController/erizoController.js b/erizo_controller/test/erizoController/erizoController.js
@@ -54,9 +54,9 @@ describe('Erizo Controller / Erizo Controller', () => {
   });
 
   it('should have a known API', () => {
-    expect(controller.getUsersInRoom).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.deleteUser).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.deleteRoom).not.to.be.undefined;  // jshint ignore:line
+    expect(controller.getUsersInRoom).not.to.be.undefined;
+    expect(controller.deleteUser).not.to.be.undefined;
+    expect(controller.deleteRoom).not.to.be.undefined;
   });
 
   it('should be added to Nuve', () => {

diff --git a/erizo_controller/test/erizoController/roomController.js b/erizo_controller/test/erizoController/roomController.js
@@ -40,15 +40,15 @@ describe('Erizo Controller / Room Controller', () => {
   });
 
   it('should have a known API', () => {
-    expect(controller.addEventListener).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.addExternalInput).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.addExternalOutput).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.processSignaling).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.addPublisher).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.addSubscriber).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.removePublisher).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.removeSubscriber).not.to.be.undefined;  // jshint ignore:line
-    expect(controller.removeSubscriptions).not.to.be.undefined;  // jshint ignore:line
+    expect(controller.addEventListener).not.to.be.undefined;
+    expect(controller.addExternalInput).not.to.be.undefined;
+    expect(controller.addExternalOutput).not.to.be.undefined;
+    expect(controller.processSignaling).not.to.be.undefined;
+    expect(controller.addPublisher).not.to.be.undefined;
+    expect(controller.addSubscriber).not.to.be.undefined;
+    expect(controller.removePublisher).not.to.be.undefined;
+    expect(controller.removeSubscriber).not.to.be.undefined;
+    expect(controller.removeSubscriptions).not.to.be.undefined;
   });
 
   describe('External Input', () => {

diff --git a/erizo_controller/test/erizoJS/erizoJSController.js b/erizo_controller/test/erizoJS/erizoJSController.js
@@ -431,7 +431,7 @@ describe('Erizo JS Controller', () => {
             } });
 
           expect(mocks.MediaStream.setSlideShowMode.callCount).to.equal(1);
-          expect(mocks.MediaStream.setSlideShowMode.args[0][0]).to.be.true;  // jshint ignore:line
+          expect(mocks.MediaStream.setSlideShowMode.args[0][0]).to.be.true;
         });
 
         it('should set slide show mode to false', () => {
@@ -441,7 +441,7 @@ describe('Erizo JS Controller', () => {
               slideShowMode: false,
             } });
 
-          expect(mocks.MediaStream.setSlideShowMode.args[0][0]).to.be.false;  // jshint ignore:line
+          expect(mocks.MediaStream.setSlideShowMode.args[0][0]).to.be.false;
         });
       });