better message for processing "time" and bug solved

davidbuzatto · Oct 14, 2023 · f653b63 · f653b63
1 parent 933d554
commit f653b63
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/src/main/java/br/com/davidbuzatto/yaas/gui/MainWindow.java b/src/main/java/br/com/davidbuzatto/yaas/gui/MainWindow.java
@@ -1068,7 +1068,9 @@ public void run() {
 
     private void openExample() {
         if ( ApplicationConstants.IN_DEVELOPMENT ) {
-            createTMInternalFrame( TMExamples.createDTMMonusHalt(), true, true, "0000100", TMAcceptanceType.HALT );
+            createTMInternalFrame( 
+                    TMExamples.createDTMDivideHalt(), true, true, 
+                    "00001001", TMAcceptanceType.HALT );
         }
     }
 

diff --git a/src/main/java/br/com/davidbuzatto/yaas/gui/tm/TMInternalFrame.java b/src/main/java/br/com/davidbuzatto/yaas/gui/tm/TMInternalFrame.java
@@ -98,6 +98,14 @@ public class TMInternalFrame extends javax.swing.JInternalFrame {
     private static final String MODEL_PROPERTIES_CARD = "model";
     private static final String STATE_PROPERTIES_CARD = "state";
     private static final String TRANSITION_PROPERTIES_CARD = "transition";
+    private static final String MAX_COUNT_ERROR_MESSAGE = String.format(
+            """
+            It seems that the designed Turing Machine doesn't halt!
+            
+            Since YAAS can store around %d transitions in tests, 
+            either your input takes too long to be processed, or you
+            have an infinite loop.
+            """, ApplicationConstants.TURING_MACHINE_MAX_COUNT );
 
     private TM tm;
     private MainWindow mainWindow;
@@ -1526,8 +1534,7 @@ private void btnStartActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRS
                     drawPanel.requestFocus();
 
                 } else {
-                    Utils.showErrorMessage( this, 
-                            "The designed Turing Machine never halts!" );
+                    Utils.showErrorMessage( this, MAX_COUNT_ERROR_MESSAGE );
                     enableGUI();
                 }
 
@@ -2293,8 +2300,7 @@ private void runSingleTest() throws HeadlessException {
                     }
 
                 } else {
-                    Utils.showErrorMessage( this, 
-                            "The designed Turing Machine never halts!" );
+                    Utils.showErrorMessage( this, MAX_COUNT_ERROR_MESSAGE );
                 }
 
             } else {

diff --git a/src/main/java/br/com/davidbuzatto/yaas/model/tm/TMID.java b/src/main/java/br/com/davidbuzatto/yaas/model/tm/TMID.java
@@ -160,6 +160,12 @@ public TMID derive( TMTransition transition, TMOperation operation ) {
             newString = CharacterConstants.BLANK_TAPE_SYMBOL + newString;
         }
 
+        if ( newPosition < 0 ) {
+            newPosition = 0;
+        } else if ( newPosition >= newString.length() ) {
+            newPosition = newString.length()-1;
+        }
+
         return new TMID( 
                 transition.getTargetState(), 
                 newString, 

diff --git a/src/main/java/br/com/davidbuzatto/yaas/util/ApplicationConstants.java b/src/main/java/br/com/davidbuzatto/yaas/util/ApplicationConstants.java
@@ -31,6 +31,6 @@ public interface ApplicationConstants {
     public static final String LIGHT_THEME = "LIGHT";
     public static final String DARK_THEME = "DARK";
 
-    public static final int TURING_MACHINE_MAX_COUNT = 2000;
+    public static final int TURING_MACHINE_MAX_COUNT = 4000;
 
 }