Merge pull request #190 from davellanedam/development

Development
davellanedam · Jan 12, 2020 · 324544f · 324544f
2 parents 253d29b + ba320bc
commit 324544f
Show file tree

Hide file tree

Showing 5 changed files with 1,784 additions and 3,371 deletions.
diff --git a/.gitignore b/.gitignore
@@ -67,3 +67,5 @@ typings/
 
 # ignore production configuration
 .env.production
+
+.history/
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## v7.1.2 (January 12, 2020)
+
+-   Added cross-env to solve windows envionment issues
+-   Use Mongoose built in function to validate ID
+-   NPM updated
+
 ## v7.1.1 (September 29, 2019)
 
 -   Added new option MongoClient constructor

diff --git a/app/middleware/utils.js b/app/middleware/utils.js
@@ -1,3 +1,4 @@
+const mongoose = require('mongoose')
 const requestIp = require('request-ip')
 const { validationResult } = require('express-validator')
 
@@ -96,7 +97,7 @@ exports.buildSuccObject = message => {
  */
 exports.isIDGood = async id => {
   return new Promise((resolve, reject) => {
-    const goodID = String(id).match(/^[0-9a-fA-F]{24}$/)
+    const goodID = mongoose.Types.ObjectId.isValid(id)
     return goodID
       ? resolve(id)
       : reject(this.buildErrObject(422, 'ID_MALFORMED'))
Original file line number	Diff line number	Diff line change
Expand Up		@@ -67,3 +67,5 @@ typings/

		# ignore production configuration
		.env.production

		.history/