Change default bind address to the unspecified address 0.0.0.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default bind address is currently 127.0.0.1, which means we always use the loopback device and cannot connect to a remote host unless we pass in a socket / bind address in the config.
For me, this means the hyperswarm-rs hyperchat example will not work when the given bootstrap node is a remote host, even if we pass in a non-loopback ip using the
--bindoption, as this option is used only to configure tcp / utp connections to peers, not where to bind the dht node.I think the default bind address should be the unspecified address (0.0.0.0) as this gives most flexibility - we can still use localhost for testing and also connect to remote hosts.