Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin/v6.4.0 dev feat/standardise df #551

Open
wants to merge 5 commits into
base: v6.4.0-dev
Choose a base branch
from

Conversation

timcadman
Copy link

This function is a replacement to ds.dataFrameFill. It should be much quicker, and offers additional flexibility in that the user can chose to also set the class of variables to be the same across cohorts and similarly the levels of factor variables.

Changes made

  • Added function ds.standardiseDf
  • Added lifecycle package to handle deprecation of functions
  • Deprecated function ds.dataFrameFill
  • Add tests for ds.standardiseDf
  • Added helper test file which is used in above tests

To test

  • Connect to a real life server, and run the tests test-standardise-df.R excluding the setup for dsLite at the start.

@timcadman timcadman changed the base branch from master to v6.4.0-dev November 8, 2024 15:13
@StuartWheater
Copy link
Member

Does this PR need some tweaking?
Its CI didn't look right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants