Handle lack of Link header when paginating #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 65.44% 65.32% -0.12%
==========================================
Files 1 1
Lines 1641 1644 +3
Branches 407 408 +1
==========================================
Hits 1074 1074
- Misses 465 468 +3
Partials 102 102 ☔ View full report in Codecov by Sentry. |
|
Just for the reference -- where did you run into this case when you haven't ran into it before? |
|
@yarikoptic A scheduled test run last night failed because of this. I don't know how that happened, as all the paginated requests the script makes should be to things that always have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.