Addressed PR comments

dataform-co · Feb 5, 2025 · d972f35 · d972f35
1 parent 0fc1074
commit d972f35
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/core/actions/data_preparation.ts b/core/actions/data_preparation.ts
@@ -401,18 +401,8 @@ export class DataPreparation extends ActionBuilder<dataform.DataPreparation> {
       return dataform.LoadConfiguration.create({"replace": {}});
     }
 
-    if (typeof loadMode === "number") {
-      switch (loadMode) {
-        case dataform.ActionConfig.LoadMode.REPLACE: return dataform.LoadConfiguration.create({"replace": {}});
-        case dataform.ActionConfig.LoadMode.APPEND: return dataform.LoadConfiguration.create({"append": {}});
-        case dataform.ActionConfig.LoadMode.MAXIMUM: return dataform.LoadConfiguration.create({"maximum": {"columnName": this.validateLoadModeColumnName(columnName)}});
-        case dataform.ActionConfig.LoadMode.UNIQUE: return dataform.LoadConfiguration.create({"unique": {"columnName": this.validateLoadModeColumnName(columnName)}});
-        default: throw new Error(`LoadMode value "${loadMode}" is not supported`);
-      }
-    }
-
     switch (loadMode.toString().toUpperCase()) {
-      case "REPLACE": return dataform.LoadConfiguration.create({"replace": {}});
+      case "REPLACE_TABLE": return dataform.LoadConfiguration.create({"replace": {}});
       case "APPEND": return dataform.LoadConfiguration.create({"append": {}});
       case "MAXIMUM": return dataform.LoadConfiguration.create({"maximum": {"columnName": this.validateLoadModeColumnName(columnName)}});
       case "UNIQUE": return dataform.LoadConfiguration.create({"unique": {"columnName": this.validateLoadModeColumnName(columnName)}});

diff --git a/protos/configs.proto b/protos/configs.proto
@@ -558,7 +558,7 @@ message ActionConfig {
 
   enum LoadMode {
     // Replace existing table (default).
-    REPLACE = 0;
+    REPLACE_TABLE = 0;
     // Insert into destination table.
     APPEND = 1;
     // Insert only records where the specified column value exceeds the existing maximum value in the destination table.