Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the year from the beername #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 26, 2022

No description provided.

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INTEGRATION.BEERS.BEERS
main fd-remove-beer-year-from-the-name
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 7 8
💬 Mismatched columns 1 2 (0 reorders, 1 type changes)
Primary keys diff (beer_id)
🔍  Primary-key inferred from tests
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 5 compared)
💬 Total differing rows 240 / 2,410 (10.0%)
💬 Total differing values 2.0%

View diff details →


Diffs of downstream tables

INTEGRATION.BEERS.PROMO_DELIVERIES
main fd-remove-beer-year-from-the-name
💬 Total rows 88 84 (-4.5%)
Schema diff
💬 Total columns 3 3
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (customer_id)
💬 Distinct PKs 88 84 (-4.5%)
💬 Exclusive PKs 88 (100%) 84 (100%)
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 2 compared) ✔️
💬 Total differing rows 0 / 0 (-/-) ✔️
💬 Total differing values -/- ✔️

View diff details →


INTEGRATION.BEERS.ORDER_LINES
main fd-remove-beer-year-from-the-name
💬 Total rows 900 900 (0%)
Schema diff
💬 Total columns 7 7
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 900 900 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 2 (out of 5 compared)
💬 Total differing rows 900 / 900 (100%)
💬 Total differing values 40%

View diff details →


INTEGRATION.BEERS.SALES
main fd-remove-beer-year-from-the-name
💬 Total rows 810 810 (0%)
Schema diff
💬 Total columns 17 17
💬 Mismatched columns 2 2 (0 reorders, 1 type changes)
Primary keys diff (order_no, order_line)
💬 Distinct PKs 810 810 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 13 compared) ✔️
💬 Total differing rows 0 / 810 (0%) ✔️
💬 Total differing values 0% ✔️

View diff details →


INTEGRATION.BEERS.BEERS_WITH_BREWERIES
main fd-remove-beer-year-from-the-name
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 11 12
💬 Mismatched columns 1 2 (0 reorders, 1 type changes)
Primary keys diff (brewery_id, beer_id, beer_name)
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 240 (10.0%) 240 (10.0%)
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 7 compared) ✔️
💬 Total differing rows 0 / 2,170 (0%) ✔️
💬 Total differing values 0% ✔️

View diff details →


Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs of tables modified in this pull request: ⚠️ - 1
INTEGRATION.BEERS.BEERS
main fd-remove-beer-year-from-the-name
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 7 8
💬 Mismatched columns 1 2 (0 reorders, 1 type changes) ⚠️
Primary keys diff (BEER_ID)
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 5 compared) ⚠️
💬 Total differing rows 10 / 2,410 (0.41%) ⚠️
💬 Total differing values 0.083% ⚠️
View diff details →


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant