Buffer params #516
Merged
Buffer params #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 18, 2024 16:44
(non-extra param st_buffer passes tests)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 93.74% 93.66% -0.09%
==========================================
Files 245 245
Lines 6317 6342 +25
Branches 110 110
==========================================
+ Hits 5922 5940 +18
- Misses 395 402 +7
|
added 10 commits
January 21, 2024 23:25
(build succeeds)
to avoid merge conflict
milos-colic
approved these changes
Feb 1, 2024
|
UPDATE: i successfully retriggered the builds -- it's now codecov that trips. 🤷 @milos-colic thanks for the approval! -- I cannot merge due to the above build failures, however I notice that it is failing on the same GDAL issue as other, already merged PR builds, so probably unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #486
Introduces the optional parameter
buffer_style_parameters='quad_segs=# endcap=round|flat|square'where "#" is the number of line segments used to approximate a quarter circle (default is 8); and endcap style for line features is one of listed (default="round")Compatible with the same name parameter in PostGIS ST_Buffer