Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kepler magic add additional feature_type values to usage docs #514

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

kieranross89
Copy link

@kieranross89 kieranross89 commented Jan 18, 2024

Minor update to the Kepler usage documentation to include additional feature_type values that can be used to plot data that utilises British National Grid (BNG).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@milos-colic
Copy link
Contributor

@kieranross89 thanks for the PR, can you please sing the CLA above? Then I can merge the PR. Thanks!

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f425ba5) 93.86% compared to head (a38b94d) 93.86%.
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         241      241           
  Lines        6241     6241           
  Branches      108      108           
=======================================
  Hits         5858     5858           
  Misses        383      383           

@kieranross89
Copy link
Author

@kieranross89 thanks for the PR, can you please sing the CLA above? Then I can merge the PR. Thanks!

It appears to have been signed but the recheck option is not picking it up

@kieranross89
Copy link
Author

@milos-colic still not getting the CLA to pick up that it has been singed. As far as I can tell my side it appears okay?

@milos-colic
Copy link
Contributor

@kieranross89 we can use comments hear as acknowledgement of CLA by you. Not sure why the plugin isnt picking it up.

@milos-colic milos-colic merged commit 3b2087b into databrickslabs:main Feb 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants