Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix raster to grid #512

Merged
merged 30 commits into from
Mar 6, 2024
Merged

Feature/fix raster to grid #512

merged 30 commits into from
Mar 6, 2024

Conversation

milos-colic
Copy link
Contributor

No description provided.

# Conflicts:
#	src/main/scala/com/databricks/labs/mosaic/functions/MosaicContext.scala
#	src/test/scala/com/databricks/labs/mosaic/datasource/multiread/RasterAsGridReaderTest.scala
#	src/test/scala/org/apache/spark/sql/test/SharedSparkSessionGDAL.scala
Copy link
Contributor

@mjohns-databricks mjohns-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fix temp location utils.
Separate temp on worker location and off worker location.
Introduce GDAL Block notion.
Implement Kernel filters via GDALBlocks.
Add additional params to gdal programs when they run.
Fix TILED=YES issue with TIF files.
Introduce writeOptions concept for tmp writes.
Update expressions to take into account new concepts.
Fix Zarr format issues with SerDeser.
@milos-colic milos-colic marked this pull request as ready for review February 1, 2024 15:55
Copy link
Contributor

@mjohns-databricks mjohns-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 88.56570% with 114 lines in your changes are missing coverage. Please review.

Project coverage is 93.58%. Comparing base (a7ab70b) to head (c539615).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   93.74%   93.58%   -0.17%     
==========================================
  Files         245      260      +15     
  Lines        6317     7059     +742     
  Branches      110      124      +14     
==========================================
+ Hits         5922     6606     +684     
- Misses        395      453      +58     
Files Coverage Δ
...cks/labs/mosaic/core/raster/api/FormatLookup.scala 100.00% <100.00%> (ø)
...ic/core/raster/gdal/MosaicRasterWriteOptions.scala 100.00% <100.00%> (ø)
...core/raster/operator/clip/RasterClipByVector.scala 100.00% <100.00%> (ø)
...osaic/core/raster/operator/gdal/GDALBuildVRT.scala 100.00% <100.00%> (+14.28%) ⬆️
...bs/mosaic/core/raster/operator/gdal/GDALCalc.scala 92.00% <100.00%> (+17.00%) ⬆️
...saic/core/raster/operator/gdal/GDALTranslate.scala 100.00% <100.00%> (+12.50%) ⬆️
...bs/mosaic/core/raster/operator/gdal/GDALWarp.scala 100.00% <100.00%> (+12.50%) ⬆️
...saic/core/raster/operator/merge/MergeRasters.scala 100.00% <100.00%> (ø)
...re/raster/operator/pixel/PixelCombineRasters.scala 100.00% <100.00%> (ø)
...saic/core/raster/operator/proj/RasterProject.scala 100.00% <100.00%> (ø)
... and 95 more

... and 1 file with indirect coverage changes

milos.colic and others added 18 commits February 13, 2024 14:13
# Conflicts:
#	src/main/scala/com/databricks/labs/mosaic/core/raster/gdal/MosaicRasterBandGDAL.scala
#	src/main/scala/com/databricks/labs/mosaic/core/raster/gdal/MosaicRasterGDAL.scala
#	src/main/scala/com/databricks/labs/mosaic/core/raster/operator/clip/RasterClipByVector.scala
#	src/main/scala/com/databricks/labs/mosaic/core/raster/operator/gdal/GDALCalc.scala
#	src/main/scala/com/databricks/labs/mosaic/core/raster/operator/retile/RasterTessellate.scala
#	src/main/scala/com/databricks/labs/mosaic/gdal/MosaicGDAL.scala
#	src/test/scala/com/databricks/labs/mosaic/expressions/raster/RST_TessellateBehaviors.scala
Add createInfo concept, this will contain driver, parentPath, currentPath, etc.
Make gdal programs no-failure operations.
Capture errors and warnings of gdal programs in the raster tile metadata.
Add RST_Transform expression.
Add ReadAsPath reading strategy.
@milos-colic
Copy link
Contributor Author

@sllynn @mjohns-databricks this is ready for review.
Code coverage is broken but it is only -0.17% which is likely just a couple of lines that were missed.

Copy link
Contributor

@mjohns-databricks mjohns-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milos-colic milos-colic merged commit 8701525 into main Mar 6, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants