-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix raster to grid #512
Conversation
Refactor RasterToGrid readers.
# Conflicts: # src/main/scala/com/databricks/labs/mosaic/functions/MosaicContext.scala # src/test/scala/com/databricks/labs/mosaic/datasource/multiread/RasterAsGridReaderTest.scala # src/test/scala/org/apache/spark/sql/test/SharedSparkSessionGDAL.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix temp location utils. Separate temp on worker location and off worker location. Introduce GDAL Block notion. Implement Kernel filters via GDALBlocks. Add additional params to gdal programs when they run. Fix TILED=YES issue with TIF files. Introduce writeOptions concept for tmp writes. Update expressions to take into account new concepts. Fix Zarr format issues with SerDeser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 93.74% 93.58% -0.17%
==========================================
Files 245 260 +15
Lines 6317 7059 +742
Branches 110 124 +14
==========================================
+ Hits 5922 6606 +684
- Misses 395 453 +58
|
# Conflicts: # src/main/scala/com/databricks/labs/mosaic/core/raster/gdal/MosaicRasterBandGDAL.scala # src/main/scala/com/databricks/labs/mosaic/core/raster/gdal/MosaicRasterGDAL.scala # src/main/scala/com/databricks/labs/mosaic/core/raster/operator/clip/RasterClipByVector.scala # src/main/scala/com/databricks/labs/mosaic/core/raster/operator/gdal/GDALCalc.scala # src/main/scala/com/databricks/labs/mosaic/core/raster/operator/retile/RasterTessellate.scala # src/main/scala/com/databricks/labs/mosaic/gdal/MosaicGDAL.scala # src/test/scala/com/databricks/labs/mosaic/expressions/raster/RST_TessellateBehaviors.scala
Add createInfo concept, this will contain driver, parentPath, currentPath, etc. Make gdal programs no-failure operations. Capture errors and warnings of gdal programs in the raster tile metadata. Add RST_Transform expression. Add ReadAsPath reading strategy.
… feature/fix_raster_to_grid
… feature/fix_raster_to_grid
Fix convolve operations.
@sllynn @mjohns-databricks this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.