Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect closed linestring for polygon #501

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Conversation

danielsparing
Copy link

resolves #457

@danielsparing danielsparing requested a review from sllynn January 11, 2024 22:24
@danielsparing danielsparing marked this pull request as draft January 11, 2024 22:43
@danielsparing danielsparing marked this pull request as ready for review January 11, 2024 23:04
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f734d66) 93.85% compared to head (f9e3fa0) 93.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   93.85%   93.84%   -0.01%     
==========================================
  Files         239      239              
  Lines        6202     6209       +7     
  Branches      108      108              
==========================================
+ Hits         5821     5827       +6     
- Misses        381      382       +1     
Files Coverage Δ
...osaic/core/geometry/polygon/MosaicPolygonJTS.scala 96.77% <100.00%> (+0.41%) ⬆️

... and 2 files with indirect coverage changes

@danielsparing danielsparing marked this pull request as draft January 12, 2024 06:25
@danielsparing danielsparing marked this pull request as ready for review January 12, 2024 07:04
@danielsparing
Copy link
Author

danielsparing commented Jan 12, 2024

For all I can tell, the failing Codecov checks are due to an earlier check (transiently?) running into calcPath == "ERROR" here, and as it is not happening in the above case, those lines are not covered anymore. So hopefully this is fine?

EDIT: here is a PR on an empty commit, with the same codecov failures, to prove the above point.

@milos-colic milos-colic merged commit 21759ae into main Jan 12, 2024
6 of 8 checks passed
@milos-colic
Copy link
Contributor

@danielsparing I have merged this, I have ignored codecoverage since it was refering error messages not being hit in an old commit.

@danielsparing danielsparing deleted the polygon-expect-closed branch January 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

st_transform duplicates the last point when transforming a polygon
2 participants