support az aware endpoints with multiple sts in one hashring #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyi
reviewed
Jan 24, 2024
christopherzli
changed the title
hczhu-db
reviewed
Jan 24, 2024
hczhu-db
reviewed
Jan 24, 2024
hczhu-db
reviewed
Jan 24, 2024
christopherzli
commented
Jan 24, 2024
christopherzli
commented
Jan 24, 2024
| @@ -5,6 +5,7 @@ | |||
| # But not these files: | |||
| @@ -283,7 +289,7 @@ func newReflectorMetrics(reg *prometheus.Registry) prometheusReflectorMetrics { | |||
|
|
|||
| const labelParts = 2 | |||
|
|
|||
| func splitLabel(in string) (key, value string) { | |||
| func splitLabel(in string) (string, string) { | |||
There was a problem hiding this comment.
nonamedreturns lint rule
| @@ -292,35 +298,35 @@ func splitLabel(in string) (key, value string) { | |||
| return parts[0], parts[1] | |||
| } | |||
|
|
|||
| func (p prometheusReflectorMetrics) NewListsMetric(name string) cache.CounterMetric { | |||
| func (p prometheusReflectorMetrics) NewListsMetric(_ string) cache.CounterMetric { | |||
main.go
Outdated
| @@ -679,6 +686,40 @@ func (c *controller) populate(ctx context.Context, hashrings []receive.HashringC | |||
| } | |||
| } | |||
|
|
|||
| func (c *controller) populateEndpoint(sts *appsv1.StatefulSet, podIndex int, err error, pod *corev1.Pod) receive.Endpoint { | |||
There was a problem hiding this comment.
extract method to reduce cognitive complexity to resolve lint errors
jnyi
reviewed
Jan 24, 2024
jnyi
approved these changes
Jan 24, 2024
|
verified in k8s that this will work |
christopherzli
commented
Jan 25, 2024
| @@ -563,9 +573,9 @@ func (c *controller) sync(ctx context.Context) { | |||
| } | |||
|
|
|||
| // If there's an increase in replicas we poll for the new replicas to be ready | |||
| if _, ok := c.replicas[hashring]; ok && c.replicas[hashring] < *sts.Spec.Replicas { | |||
| if _, ok := c.replicas[sts.Name]; ok && c.replicas[sts.Name] < *sts.Spec.Replicas { | |||
There was a problem hiding this comment.
found a bug when multiple sts pointing to same replicas, not sure whats the point of using hashring name as the key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental,
OSS PR: support az aware hashring and multiple sts in one hashring observatorium/thanos-receive-controller#129
How is this tested?
main_test.go,
Make thanos-receive-controller
pending test in deployment