Add instanceUrl validation #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change auth mode name for backward compatibility.
wangxinlei
commented
Apr 15, 2021
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| <authUri>/oauth2/v2.0/authorize</authUri> | |||
| <tokenUri>/oauth2/v2.0/token</tokenUri> | |||
| <instanceUrlValidationRegex>^https:\/\/([a-zA-Z0-9-.]+\.)?((microsoftonline\.(com|us|cn|de))|chinacloudapi\.cn)\/(.*)</instanceUrlValidationRegex> | |||
There was a problem hiding this comment.
This is for additional security enhancement to guarantee we will not go to a malicious url even someone open the twb and manually change the instanceUrl and send to a victim.
| @@ -19,6 +20,10 @@ | |||
| <scopes>2ff814a6-3304-4ab8-85cb-cd0e6f879c1d/user_impersonation</scopes> | |||
|
|
|||
| <capabilities> | |||
| <entry> | |||
| <key>OAUTH_CAP_REQUIRES_PROMPT_SELECT_ACCOUNT</key> | |||
There was a problem hiding this comment.
This is for always prompt user to select an account instead of directly log them in if they're already logged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an in-addition protection besides the dialog UI validation and is necessary.