extract peak cleaning into external tool #297
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently report percentages with 4 digits
|
Hey @syntonym, Thanks for this PR. I generally run changes to the pipeline on the tutorial data as a manual test. |
|
Hi @syntonym, did you have a chance to test this yourself? |
|
Hey Donald, I've run the pepatac.py with the two commits on the test1 data in the repository. I haven't compared the output to the unchanged pipeline. |
syntonym
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #295 describes why extracting the peak cleaning into an external tool is advantageous. I had already extracted the code lines for my personal use, I've now written the few lines to integrate it into the pipeline itself. However, it still lacks documentation and testing. Is there some documentation on testing? Should I execute the pipeline on the tutorial data to see if it runs through?