Add e2e yml for github actions #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/e2e.yml
Outdated
|
|
||
| steps: | ||
| # Pinned 1.0.0 version | ||
| - uses: haya14busa/action-workflow_run-status@967ed83efa565c257675ed70cfe5231f062ddd94 |
There was a problem hiding this comment.
use marocchino/action-workflow_run-status@54b6e87d6cb552fc5f36dbe9a722a6048725917a to avoid node 12 warnings which is deprecated.
There was a problem hiding this comment.
Please update this workflow as well:
There was a problem hiding this comment.
change done, as suggested.
.github/workflows/build.yml
Outdated
| @@ -29,7 +29,7 @@ jobs: | |||
|
|
|||
| steps: | |||
| # Pinned 1.0.0 version | |||
| - uses: haya14busa/action-workflow_run-status@967ed83efa565c257675ed70cfe5231f062ddd94 | |||
| - uses: marocchino/action-workflow_run-status@54b6e87d6cb552fc5f36dbe9a722a6048725917a | |||
| - uses: actions/checkout@v3 | |||
| with: | |||
| ref: ${{ github.event.workflow_run.head_branch }} | |||
There was a problem hiding this comment.
Although unrelated to this PR, this should be sha instead of branch. Please fix.
There was a problem hiding this comment.
Updated the change
itsankit-google
approved these changes
Nov 16, 2023
itsmekumari
force-pushed
the
e2e_githubactions
branch
from
6727491 to
0c2aa4c
Compare
Squash commits done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add e2e yml for github actions