fix(uphold): use crypto_withdrawals capability for transfer permission (

#1243)
dashpay · Jan 4, 2024 · b958570 · b958570
1 parent db3985f
commit b958570
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/integrations/uphold/ERRORS.md b/integrations/uphold/ERRORS.md
@@ -154,7 +154,7 @@ Error: 403
 ```json
 {
   "error": {
-    "capability": "withdrawals",
+    "capability": "crypto_withdrawals",
     "code": "forbidden",
     "message": "Quote not allowed due to capability constraints",
     "requirements": [],

diff --git a/integrations/uphold/src/main/java/org/dash/wallet/integrations/uphold/api/UpholdClientExt.kt b/integrations/uphold/src/main/java/org/dash/wallet/integrations/uphold/api/UpholdClientExt.kt
@@ -150,7 +150,7 @@ suspend fun UpholdClient.revokeAccessToken() {
 }
 
 suspend fun UpholdClient.checkCapabilities() {
-    val operation = "withdrawals"
+    val operation = "crypto_withdrawals"
     val response = service.getCapabilities(operation)
     response.ensureSuccessful()
     val capability = response.body()
@@ -207,7 +207,7 @@ fun UpholdClient.createDashAddress(cardId: String) {
 }
 
 fun UpholdClient.getWithdrawalRequirements(): List<String> {
-    val result = requirements["withdrawals"]
+    val result = requirements["crypto_withdrawals"]
     return result ?: emptyList()
 }
 

diff --git a/...ons/uphold/src/main/java/org/dash/wallet/integrations/uphold/data/UpholdApiException.java b/...ons/uphold/src/main/java/org/dash/wallet/integrations/uphold/data/UpholdApiException.java
@@ -236,7 +236,7 @@ private Date convertISO8601Date(String date) {
 
     //  403
     //  {
-    //       "capability":"withdrawals",
+    //       "capability":"crypto_withdrawals",
     //       "code":"forbidden",
     //       "message":"Quote not allowed due to capability constraints",
     //       "requirements":[],

diff --git a/integrations/uphold/src/test/java/org/dash/wallet/integrations/uphold/UpholdClientTest.kt b/integrations/uphold/src/test/java/org/dash/wallet/integrations/uphold/UpholdClientTest.kt
@@ -122,7 +122,7 @@ class UpholdClientTest {
             listOf()
         )
 
-        val actualResponse = api.getCapabilities("withdrawals")
+        val actualResponse = api.getCapabilities("crypto_withdrawals")
         assertEquals(expected, actualResponse.body())
     }
 

diff --git a/integrations/uphold/src/test/java/org/dash/wallet/integrations/uphold/UpholdErrorTest.kt b/integrations/uphold/src/test/java/org/dash/wallet/integrations/uphold/UpholdErrorTest.kt
@@ -61,7 +61,7 @@ class UpholdErrorTest {
 
         val thirdError = """
             {
-                "capability": "withdrawals",
+                "capability": "crypto_withdrawals",
                 "code": "forbidden",
                 "message": "Quote not allowed due to capability constraints",
                 "requirements": [],