-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated detection of Node and Japa test runners #96
Conversation
I think we can go further by checking if the test script contains another script instead of looking for In this example, we can detect that Another way would be checking all scripts that contains (or starts with) |
I @PierreDemailly, The second approach seems easier to implement, while the first one offers greater flexibility. So, which solution would you prefer us to focus on? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Well rated |
@fabnguess Nevermind i'm dumb 🤣 |
ea6a43c
to
85d71ad
Compare
85d71ad
to
7884d0f
Compare
7884d0f
to
c8a85d2
Compare
c8a85d2
to
4bafc42
Compare
4bafc42
to
eb88752
Compare
This PR aims to improve the detection of test runners used in projects, particularly for Node.js and Japa.
Currently the code only checks the test script in the package.json file. However, in many projects it is the test-only script that is responsible for running the tests. This prevents correct detection of Node's test runner.
Proposed changes:
Test-only script support: The code has been changed to also check the test-only script in the package.json file, in addition to the test script.
Japa verification: As per Japa documentation, the presence of @japa/runner in devDependencies is now checked to identify projects using Japa as a test runner.