This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
feat: get block header by hash + store by height #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Aug 21, 2020
| if (err && err.name === 'NotFoundError') { | ||
| resolve(null); | ||
| } else if (err) { | ||
| reject(err.message); | ||
| } else { | ||
| resolve(JSON.parse(data.toString())); |
There was a problem hiding this comment.
Can we just introduce two functions:
- getByHeight
- getByHash
There was a problem hiding this comment.
Does the last commit fix that need ?
shumkov
reviewed
Aug 22, 2020
| * @param {String|Number} identifier - Hash or height block identifier | ||
| * @returns {Promise<BlockHeader>} | ||
| */ | ||
| async get(identifier) { |
There was a problem hiding this comment.
May be don’t need a ploymorphic param here as well?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This PR allow to store and fetch BlockHeader by their height.
Checklist: