Skip to content

Commit

Permalink
[vm_service] Renamed badly named tests to _test.dart
Browse files Browse the repository at this point in the history
We've accumulated some tests that wasn't named as such, thus not
actually being run.

Change-Id: Ia42a99de14312af6f7b3ddfa5a107b74bf5ae663
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400320
Reviewed-by: Derek Xu <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>
  • Loading branch information
jensjoha authored and Commit Queue committed Dec 13, 2024
1 parent 91ba697 commit aa6ed3f
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 6 deletions.
1 change: 1 addition & 0 deletions pkg/pkg.status
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ vm_service/test/issue_27238_test: SkipByDesign # Debugger is disabled in AOT mod
vm_service/test/issue_27287_test: SkipByDesign # Debugger is disabled in AOT mode.
vm_service/test/issue_30555_test: SkipByDesign # Debugger is disabled in AOT mode.
vm_service/test/issue_56911_test: SkipByDesign # Debugger is disabled in AOT mode.
vm_service/test/issue_59661_test: SkipByDesign # Debugger is disabled in AOT mode.
vm_service/test/kill_paused_test: SkipByDesign # Debugger is disabled in AOT mode.
vm_service/test/library_dependency_test: SkipByDesign # Uses 'dart:mirrors' library.
vm_service/test/local_variable_declaration_test: SkipByDesign # Debugger is disabled in AOT mode.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ extension type Foo(int value) {
debugger();
print("This foos value is '$value'");
}

int otherCall() {
return value * 2;
}
Expand Down Expand Up @@ -64,6 +65,6 @@ final testSteps = <IsolateTest>[
Future<void> main([args = const <String>[]]) => runIsolateTests(
args,
testSteps,
'eval_inside_extension_type_method.dart',
'eval_inside_extension_type_method_test.dart',
testeeConcurrent: testFunction,
);
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ extension type Foo(int value) {
void printFoo() {
print("This foos value is '$value'");
}

int otherCall() {
return value * 2;
}
Expand Down Expand Up @@ -66,6 +67,6 @@ final testSteps = <IsolateTest>[
Future<void> main([args = const <String>[]]) => runIsolateTests(
args,
testSteps,
'eval_on_extension_type.dart',
'eval_on_extension_type_test.dart',
testeeConcurrent: testFunction,
);
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ final tests = <IsolateTest>[
void main([args = const <String>[]]) => runIsolateTests(
args,
tests,
'eval_skip_breakpoint.dart',
'eval_skip_breakpoint_test.dart',
testeeConcurrent: testMain,
);
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var tests = <VMTest>[
expect(
e.details,
contains(
"getMemoryUsage: invalid 'isolateGroupId' parameter: badid",
"getMemoryUsage: invalid 'isolateId' parameter: badid",
),
);
}
Expand All @@ -37,5 +37,5 @@ var tests = <VMTest>[
void main([args = const <String>[]]) => runVMTests(
args,
tests,
'get_isolate_group_memory_usage.dart',
'get_isolate_group_memory_usage_test.dart',
);
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ final tests = <IsolateTest>[
void main([args = const <String>[]]) => runIsolateTests(
args,
tests,
'invoke_skip_breakpoint.dart',
'invoke_skip_breakpoint_test.dart',
testeeConcurrent: testMain,
);

0 comments on commit aa6ed3f

Please sign in to comment.