-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement command "unpack" #4111
Conversation
lib/src/command/unpack.dart
Outdated
|
||
@override | ||
String get description => 'Downloads a package and unpacks it in place.\n' | ||
'Will resolve dependencies in the folder unless `--no-resolve` is passed.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the kind of thing where you write:
<summary>\n\n<longer_description>
And shouldn't longer_description
include examples, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more examples and an extra newline.
Nice. Can we bring over the support for |
I don't think it will work well - usually the example folder will have a path dependency on the main library, and that cannot resolve if we extract it out of context. |
Oh, I had not thought of that (but just sampled some top packages, and you are absolutely right; it's very common). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4102