Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most AssetNode subtypes. #3906

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Mar 5, 2025

For #3811.

Remove subtypes that don't add any fields.

Improve naming in a few places, at least I hope these are clearer :) suggestions welcome.

syntheticSource -> missingSource
isReadable -> isFile
isInteresting -> changesRequireRebuild
isValidInput -> isTrackedInput

Improved docs in a few places.

Copy link

github-actions bot commented Mar 5, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Copy link

github-actions bot commented Mar 5, 2025

PR Health

Changelog Entry
Package Changed Files
package:build_runner build_runner/lib/src/watcher/change_filter.dart
package:build_runner_core build_runner_core/lib/src/asset/finalized_reader.dart
build_runner_core/lib/src/asset_graph/graph.dart
build_runner_core/lib/src/asset_graph/node.dart
build_runner_core/lib/src/asset_graph/serialization.dart
build_runner_core/lib/src/generate/build_definition.dart
build_runner_core/lib/src/generate/build_impl.dart
build_runner_core/lib/src/generate/finalized_assets_view.dart
build_runner_core/lib/src/generate/single_step_reader_writer.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@davidmorgan davidmorgan requested a review from jensjoha March 5, 2025 10:08
@davidmorgan davidmorgan merged commit 8a1fd97 into dart-lang:master Mar 5, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants