Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeType to AssetNode. #3905

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Add NodeType to AssetNode. #3905

merged 1 commit into from
Mar 5, 2025

Conversation

davidmorgan
Copy link
Contributor

For #3811.

Stop using type checks where they don't give access to more fields, use the enum instead. Remove mixins.

Next PR will remove the types that are no longer needed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

PR Health

@davidmorgan davidmorgan requested a review from jensjoha March 5, 2025 09:29
@davidmorgan davidmorgan merged commit 4582e2d into dart-lang:master Mar 5, 2025
83 of 84 checks passed
@davidmorgan davidmorgan deleted the node-type-enum branch March 5, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensjoha jensjoha jensjoha approved these changes

Assignees
No one assigned
Labels
skip-changelog-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmorgan @jensjoha