Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest pkg:js in pkg:build_runner and pkg:build_web_compilers #3640

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Support latest pkg:js in pkg:build_runner and pkg:build_web_compilers #3640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf4b392
Support latest pkg:js in pkg:build_runner and pkg:build_web_compilers
kevmoo Jan 11, 2024
eebf616
update build_modules and build_web_compilers for the latest package:js
jakemac53 Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_modules/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.0.7

- Fixes to support package:js version 0.7.0.

## 5.0.6

- Allow version 3.4.x of the Dart SDK.
Expand Down
3 changes: 2 additions & 1 deletion build_modules/lib/src/module_library.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ class ModuleLibrary {
if (parsed.directives.any((d) =>
d is UriBasedDirective &&
d.uri.stringValue?.startsWith('dart:_') == true &&
id.package != 'dart_internal')) {
id.package != 'dart_internal' &&
id.package != 'js')) {
return ModuleLibrary._nonImportable(id);
}
if (_isPart(parsed)) {
Expand Down
2 changes: 1 addition & 1 deletion build_modules/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_modules
version: 5.0.6
version: 5.0.7
description: >-
Builders to analyze and split Dart code into individually compilable modules
based on imports.
Expand Down
3 changes: 2 additions & 1 deletion build_runner/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
## 2.4.8-wip
## 2.4.8

- Update README.md to point to the FAQ and other docs.
- Print stack traces for `Error` subtype exceptions in non-verbose mode.
- Support latest version of `package:js`.

## 2.4.7

Expand Down
4 changes: 2 additions & 2 deletions build_runner/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_runner
version: 2.4.8-wip
version: 2.4.8
description: A build system for Dart code generation and modular compilation.
repository: https://github.com/dart-lang/build/tree/master/build_runner

Expand Down Expand Up @@ -29,7 +29,7 @@ dependencies:
graphs: ^2.2.0
http_multi_server: ^3.0.0
io: ^1.0.0
js: ^0.6.3
js: '>=0.6.3 <0.8.0'
logging: ^1.0.0
meta: ^1.3.0
mime: ^1.0.0
Expand Down
5 changes: 5 additions & 0 deletions build_web_compilers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 4.0.9

- Support latest version of `package:js`.
- Allow `dart:_js_annotations` on web platforms.

## 4.0.8

- Allow version 3.4.x of the Dart SDK.
Expand Down
1 change: 1 addition & 0 deletions build_web_compilers/lib/src/platforms.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import 'package:build_modules/build_modules.dart';

const _libraries = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brain always goes to "this should be a Set" but no biggy...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, you aren't wrong, but it also doesn't matter here in practice :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I know. 😉

'_internal',
'_js_annotations',
'async',
'collection',
'convert',
Expand Down
4 changes: 2 additions & 2 deletions build_web_compilers/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_web_compilers
version: 4.0.8
version: 4.0.9
description: Builder implementations wrapping the dart2js and DDC compilers.
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers

Expand All @@ -15,7 +15,7 @@ dependencies:
build_modules: ^5.0.0
collection: ^1.15.0
glob: ^2.0.0
js: ^0.6.3
js: '>=0.6.3 <0.8.0'
logging: ^1.0.0
path: ^1.8.0
pool: ^1.5.0
Expand Down
Loading