Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Commit

Permalink
test on oldest supported SDK (#48)
Browse files Browse the repository at this point in the history
* update min sdk
* Fix references to dartlang.org
  • Loading branch information
kevmoo authored Apr 21, 2020
1 parent 7e6a2a4 commit eec1081
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ language: dart

dart:
- dev
- 2.2.0

dart_task:
- test
- dartanalyzer
- dartanalyzer: --fatal-infos --fatal-warnings .

matrix:
include:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Fixed issue where throwing `RpcException.methodNotFound` in an asynchronous
fallback handler would not result in the next fallback being executed.
* Updated minimum SDK to Dart `2.2.0`.

## 2.1.0

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: >-
homepage: https://github.com/dart-lang/json_rpc_2

environment:
sdk: ">=2.0.0 <3.0.0"
sdk: ">=2.2.0 <3.0.0"

dependencies:
stack_trace: ^1.0.0
Expand Down
8 changes: 4 additions & 4 deletions test/server/parameters_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ void main() {
'string': 'zap',
'list': [1, 2, 3],
'date-time': '1990-01-01 00:00:00.000',
'uri': 'http://dartlang.org',
'uri': 'https://dart.dev',
'invalid-uri': 'http://[::1',
'map': {'num': 4.2, 'bool': false}
});
Expand All @@ -34,7 +34,7 @@ void main() {
'string': 'zap',
'list': [1, 2, 3],
'date-time': '1990-01-01 00:00:00.000',
'uri': 'http://dartlang.org',
'uri': 'https://dart.dev',
'invalid-uri': 'http://[::1',
'map': {'num': 4.2, 'bool': false}
}));
Expand Down Expand Up @@ -241,12 +241,12 @@ void main() {
});

test('[].asUri returns URI parameters', () {
expect(parameters['uri'].asUri, equals(Uri.parse('http://dartlang.org')));
expect(parameters['uri'].asUri, equals(Uri.parse('https://dart.dev')));
});

test('[].asUriOr returns URI parameters', () {
expect(parameters['uri'].asUriOr(Uri.parse('http://google.com')),
equals(Uri.parse('http://dartlang.org')));
equals(Uri.parse('https://dart.dev')));
});

test('[].asUri fails for non-URI parameters', () {
Expand Down

0 comments on commit eec1081

Please sign in to comment.