-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimultaneousAttack-port v6R5 #222
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also please update the metadata of this plugin to reflect the fact that it works for round 5?
@ichub this is a duplicate of @davidryan59 PR #190, i think we should rather stick with 190. While @Stx69 on this PR rewrote the following move:
to: df.move(attacker.locationId, target.locationId, Math.floor(attacker.energy * 0.5), 0, null, false); And @davidryan59 PR to: df.move(attacker.locationId, target.locationId, Math.floor(attacker.energy * energyPercent * 0.01), 0); Still the PR from @davidryan59 does a bit more, and i think we should rather approve that PR first since it also first in the line. |
OK |
import pg , and nitpick line. Thanks for your patience.
Simple port to v5R6