Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to update Dapr. #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions .github/workflows/version-update.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
#
# Copyright 2025 The Dapr Authors
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# http://www.apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

name: update-dapr-version

on:
workflow_dispatch:
inputs:
rel_version:
description: 'Dapr release version (examples: 1.9.0-rc.1, 1.9.1)'
required: true
type: string

jobs:
update-longhauls:
name: Update the dapr version in longhaul tests
runs-on: ubuntu-latest
permissions:
contents: write
env:
LONG_HAUL_REPO: test-infra
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v4
- name: Checkout the dapr repo
uses: actions/checkout@v4
with:
repository: dapr/dapr
path: .dapr_repo
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install pcre2-utils
pip install packaging
Copy link
Contributor

@elena-kolevska elena-kolevska Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install packaging
pip install semver

I suggest we move the compare_versions.py file from the dapr repo to this repo and update it so it uses the semver package instead of the packaging one that uses the PEP440 standard for version validation and comparison.

- name: Parse release version and set REL_VERSION and LATEST_RELEASE
run: python .dapr_repo/.github/scripts/get_release_version.py ${{ github.event_name }}
- name: Compare versions and determine if update of long haul tests is required
id: compare_versions
run: |
# Thanks to https://ihateregex.io/expr/semver/
SEMVER_REGEX='^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'
REL_VERSION=`echo "${{ inputs.rel_version }}" | sed -r 's/^[vV]?([0-9].+)$/\1/'`
if [ `echo $REL_VERSION | pcre2grep "$SEMVER_REGEX"` ]; then
echo "$REL_VERSION is a valid semantic version."
else
echo "$REL_VERSION is not a valid semantic version."
exit 1
fi
Comment on lines +50 to +58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Thanks to https://ihateregex.io/expr/semver/
SEMVER_REGEX='^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'
REL_VERSION=`echo "${{ inputs.rel_version }}" | sed -r 's/^[vV]?([0-9].+)$/\1/'`
if [ `echo $REL_VERSION | pcre2grep "$SEMVER_REGEX"` ]; then
echo "$REL_VERSION is a valid semantic version."
else
echo "$REL_VERSION is not a valid semantic version."
exit 1
fi
# Thanks to https://ihateregex.io/expr/semver/
SEMVER_REGEX='^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'
REL_VERSION=`echo "${{ inputs.rel_version }}" | sed -r 's/^[vV]?([0-9].+)$/\1/'`
if [ `echo $REL_VERSION | pcre2grep "$SEMVER_REGEX"` ]; then
echo "$REL_VERSION is a valid semantic version."
else
echo "$REL_VERSION is not a valid semantic version."
exit 1
fi

If we accept what I suggested in the comment above, we can also remove the regex check, because it will be covered in the compare_versions.py check below.

echo "REL_VERSION=${REL_VERSION,,}" >>${GITHUB_ENV}

EXISTING_VERSION=$(cat "config/dapr_runtime.version")
echo "Existing version in longhaul tests: $EXISTING_VERSION"
echo "New version: $REL_VERSION"
python .dapr_repo/.github/scripts/compare_versions.py "$REL_VERSION" "$EXISTING_VERSION"

- name: Update dapr runtime version in the longhaul tests repo
if: env.VERSION_UPDATE_REQUIRED == 'true'
run: |
echo "${REL_VERSION}" > config/dapr_runtime.version
- name: Commit and push changes
if: env.VERSION_UPDATE_REQUIRED == 'true'
run: |
git config --global user.name "github-actions"
git config --global user.email "[email protected]"
git add config/dapr_runtime.version
git commit -m "Updates dapr runtime version to ${REL_VERSION}"
git push