Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #963

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Update README.md #963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c75adc
Update README.md
farshaddavoudi Jan 5, 2024
6037c4d
Update README.md
farshaddavoudi Feb 14, 2024
3da3a1d
Update README.md
paulyuk Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions state_management/csharp/sdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,6 @@ This section shows how to run applications at once using [multi-app run template

1. Open a new terminal window and run `order-processor` using the multi app run template defined in [dapr.yaml](./dapr.yaml):

<!-- STEP
name: Install Dotnet dependencies
-->

```bash
dotnet restore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was failing because the dotnet build was not happening in order-processor subfolder. You could either set the working directory or cd into it.

However your simplification of restore and build made me think we should just further simplify. Dotnet language tools do a restore and build on run. So let's go straight to the run, which is done as a part of dapr run -f ..

dotnet build
```

<!-- END_STEP -->

2. Run the Dotnet service app with Dapr:

<!-- STEP
name: Run order-processor service
expected_stdout_lines:
Expand All @@ -38,14 +25,14 @@ background: true
sleep: 100
-->

```bash
paulyuk marked this conversation as resolved.
Show resolved Hide resolved
dapr run -f .
```
```bash
dapr run -f .
```

3. Stop and clean up application processes
2. Stop and clean up application processes

```bash
dapr stop -f .
dapr stop -f .
```
<!-- END_STEP -->

Expand All @@ -71,6 +58,7 @@ sleep: 15
cd ./order-processor
dapr run --app-id order-processor --resources-path ../../../resources/ -- dotnet run
```
<!-- END_STEP -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This end step was missing, which was problematic for test framework.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paulyuk, I apologize for not being able to participate and complete the job. I was busy preparing for my Azure certification exam. Thank you for approving my work.


The Terminal console output should look similar to this:

Expand All @@ -90,5 +78,6 @@ You're up and running! Both Dapr and your app logs will appear here.

2. Stop and clean up application processes

```bash
dapr stop --app-id order-processor
<!-- END_STEP -->
```
Loading