Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dapr Bindings Quickstart - .NET #1140

Closed
wants to merge 3 commits into from

Conversation

WhitWaldo
Copy link
Contributor

Description

Dapr package version bump to 1.15.0-rc02. Tweaked program to favor DI registration over the static client builder.

Issue reference

N/A - part of 1.15 endgame

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@WhitWaldo WhitWaldo requested review from a team as code owners January 21, 2025 17:41
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @WhitWaldo - thanks a lot. Agree DI is nice improvement. Please see comment. Also could you please sync to release-1.15 branch now that #1141 is in? I expect all tests to pass except for Python. See that PR for details.

bindings/csharp/sdk/batch/program.cs Outdated Show resolved Hide resolved
Co-authored-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo WhitWaldo closed this Jan 23, 2025
@WhitWaldo
Copy link
Contributor Author

Hey @WhitWaldo - thanks a lot. Agree DI is nice improvement. Please see comment. Also could you please sync to release-1.15 branch now that #1141 is in? I expect all tests to pass except for Python. See that PR for details.

@paulyuk I'm still showing that by merging to release-1.15, it's going to add #1093 to my commits which isn't related to my PR.

Might we instead create a "release-1.15-dotnet" branch on this repo that I can merge all my changes to and when I'm done, that can be merged wherever ya'll want it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants