Updates protos and fixes grpc-tools for protos generation #766
+143
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
- Coverage 86.63% 86.10% -0.53%
==========================================
Files 84 89 +5
Lines 4473 4972 +499
==========================================
+ Hits 3875 4281 +406
- Misses 598 691 +93 ☔ View full report in Codecov by Sentry. |
berndverst
reviewed
Jan 8, 2025
tools/requirements.txt
Outdated
| @@ -1 +1 @@ | |||
| grpcio-tools>=1.57.0 | |||
| grpcio-tools==1.57.0 | |||
There was a problem hiding this comment.
Suggested change
| grpcio-tools==1.57.0 | |
| grpcio-tools==1.62.3 |
I did some research and found that 1.62.3 is the latest version before protobuf 1.26.X is used which has breaking changes for Python. Let's pin this to 1.62.3 to get a newer version while maintaining compatibility with more grpcio versions (which use older protobuf versions).
There was a problem hiding this comment.
Could you use that version please and regenerate the protos? :)
berndverst
requested changes
Jan 8, 2025
Signed-off-by: Elena Kolevska <[email protected]>
berndverst
approved these changes
Jan 8, 2025
elena-kolevska
added a commit
to famarting/python-sdk
that referenced
this pull request
Jan 9, 2025
* Updates protos and fixes grpc-tools for protos generation Signed-off-by: Elena Kolevska <[email protected]> * bumps grpcio tools version Signed-off-by: Elena Kolevska <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.