Mock Actor merge #747
Closed
Mock Actor merge #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenzo Curcio <[email protected]>
berndverst
requested changes
Nov 1, 2024
Signed-off-by: Lorenzo Curcio <[email protected]>
|
@berndverst I attempted to fix it in this branch but it seems rather stubborn. I manually copied the changes to a new branch and therefore opened a new PR (#750). Will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Mock Actor capability.
NOTE: Due to some very weird bug when opening this project in a dev container (I want to love dev containers but why are they so janky) a git diff for every single file has been generated where it is overwritten with itself. I suspect this has something to do with OS specific line endings and is entirely harmless.
NOTE 2: Due to not being able to get dapr-docs running in its own dev container despite repeated attempts (I am simply not a frontend coder so i don't know how to debug all the weird errors it was spitting out), I have not been able to actually view the new documentation within a running instance of the website. I have written it nonetheless using the same templating as the others, as well as basic markdown syntax, but it would be appreciated if someone who has a develop version of the docs website working on their machine could just give it a quick look to make sure it's not somehow broken.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #737
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: