doc: document that users can self-assign issues #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KentHsu <[email protected]>
|
Thanks Kent! I also think we should add the same paragraph in the |
|
@elena-kolevska instead of directly in the As for the docs, I agree with you on the order. |
berndverst
requested changes
May 16, 2024
| @@ -8,6 +8,10 @@ description: Guidelines for contributing to the Dapr Python SDK | |||
|
|
|||
| When contributing to the [Python SDK](https://github.com/dapr/python-sdk) the following rules and best-practices should be followed. | |||
|
|
|||
| ## Github Dapr Bot Commands | |||
There was a problem hiding this comment.
Move to the end of the docs.
Signed-off-by: KentHsu <[email protected]>
|
I movedthe new paragraph to the end of python-contributing.md and decide to add the same paragraph in CONTRIBUTING.md. Please let me know if there are other documentations you want to update. |
elena-kolevska
approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
- Coverage 86.37% 86.35% -0.02%
==========================================
Files 79 82 +3
Lines 4094 4193 +99
==========================================
+ Hits 3536 3621 +85
- Misses 558 572 +14 ☔ View full report in Codecov by Sentry. |
berndverst
approved these changes
Jun 24, 2024
ksachdeva
pushed a commit
to ksachdeva/dapr-python-sdk
that referenced
this pull request
Jun 24, 2024
* doc: document that users can self-assign issues Signed-off-by: KentHsu <[email protected]> * doc: reorder paragraph and update CONTRIBUTING.md Signed-off-by: KentHsu <[email protected]> --------- Signed-off-by: KentHsu <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]>
berndverst
added a commit
that referenced
this pull request
Jun 26, 2024
…Runtime & ext/fastapi,flask (#714) * Fix Holopin alias (#706) Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]> * Add the support to pass user supplied actor_factory callable in ActorRuntime & ext/fastapi,flask Signed-off-by: Kapil Sachdeva <[email protected]> * chore - lint runtime.py & test_actor_factory.py Signed-off-by: Kapil Sachdeva <[email protected]> * Pin workflow SDK 0.4.1 in example (#715) * Pin workflow SDK 0.4.1 in example Signed-off-by: Bernd Verst <[email protected]> * fix workflow dev version Signed-off-by: Bernd Verst <[email protected]> * fix workflow example dependency Signed-off-by: Bernd Verst <[email protected]> --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]> * doc: document that users can self-assign issues (#712) * doc: document that users can self-assign issues Signed-off-by: KentHsu <[email protected]> * doc: reorder paragraph and update CONTRIBUTING.md Signed-off-by: KentHsu <[email protected]> --------- Signed-off-by: KentHsu <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]> * Standardize README shield badges (#721) Signed-off-by: Pieter de Bruin <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]> * remove unneeded import Signed-off-by: Bernd Verst <[email protected]> --------- Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: KentHsu <[email protected]> Signed-off-by: Pieter de Bruin <[email protected]> Co-authored-by: Marc Duiker <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Kent (Chia-Hao), Hsu <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Pieter de Bruin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to js-sdk, informs users about the GitHub daprbot commands available in the repo with doc link.
Issue reference
Please reference the issue this PR will close: #602
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: