-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actor state ttl support #704
Conversation
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看起來不錯。感謝你的貢獻!😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the linter errors? You can run the linter locally with tox -e flake8
.
Thanks!
(And it will also help to run the type checker locally tox -e type
and tox -e mypy
)
Apparently the lint changes might be caused by our new autoformatter. Let me see if I can revert that :) |
Signed-off-by: Bernd Verst <[email protected]>
a27eb96
to
208484c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
==========================================
- Coverage 86.37% 86.35% -0.02%
==========================================
Files 79 82 +3
Lines 4094 4193 +99
==========================================
+ Hits 3536 3621 +85
- Misses 558 572 +14 ☔ View full report in Codecov by Sentry. |
@holopin-bot @KentHsu Thank you! |
Congratulations @KentHsu, you just earned a badge! Here it is: https://holopin.io/claim/clvwgbhp1125910fjmiu9udpu8 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
This PR follows go-sdk's implementation to support actor state TTL feature
Added set_state_ttl method, updated save_state method in state_manager and added more tests
Updated state_change and state_async_provider with TTL and fix test_save_state
Issue reference
Please reference the issue this PR will close: #560
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: