Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Feature Support: Add Actor State TTL support #560

Closed
JoshVanL opened this issue Apr 25, 2023 · 4 comments · Fixed by #704
Closed

Preview Feature Support: Add Actor State TTL support #560

JoshVanL opened this issue Apr 25, 2023 · 4 comments · Fixed by #704
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@JoshVanL
Copy link

Add first class API support for Actor State TTL dapr/dapr#5899

A dedicated function to Actor State should be created. Psudo code: func (key string, value string, ttl duration). It should be made clear in the SDK documentation/comments that users should always use this function, unless they have specifically created some kind of Actor State clean up out of band of Dapr or don't have an issue with the Actor State store keep state and grow "forever".

Please see the go-sdk for implementation reference.

@artursouza artursouza added the good first issue Good for newcomers label May 15, 2023
@JoshVanL JoshVanL changed the title Add Actor State TTL support FEATURE PREVIEW: Add Actor State TTL support May 25, 2023
@JoshVanL
Copy link
Author

UPDATE: Due to the nature of the current implementation of write through caching of actor state and the unavailability of the real TTL expire time of state keys, SDKs will have an inconsistent view of the world when it has a cold cache and the state store has TTL keys. The TTL functionality has been put behind a feature gate in daprd. See dapr/dapr#6400 for more details. This feature is expected to be moved to GA in 1.12.

@berndverst berndverst changed the title FEATURE PREVIEW: Add Actor State TTL support Preview Feature Support: Add Actor State TTL support May 30, 2023
@berndverst berndverst added this to the v1.11 milestone May 30, 2023
@berndverst
Copy link
Member

At this point the SDK support will not be added until Dapr 1.12 (SDK release 1.11)

@berndverst berndverst added the help wanted Extra attention is needed label Aug 17, 2023
@berndverst berndverst modified the milestones: v1.11, v1.12 Aug 17, 2023
@berndverst berndverst modified the milestones: v1.12, v1.13 Oct 31, 2023
@dasanind
Copy link
Contributor

@berndverst Is this issue still needed to be worked on?

@berndverst berndverst modified the milestones: v1.13, v1.14 Feb 13, 2024
@KentHsu
Copy link
Contributor

KentHsu commented Apr 27, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants