Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update steps to run hello-world with ACL in selfhosted mode #996

Merged
merged 11 commits into from
Dec 12, 2020

Conversation

vinayada1
Copy link
Contributor

@vinayada1 vinayada1 commented Dec 9, 2020

Thank you for helping make the Dapr documentation better!

If you are a new contributor, please see the this contribution guidance which helps keep the Dapr documentation readable, consistent and useful for Dapr users.

Note that you must see that the suggested changes do not break the website docs.dapr.io. See this overview on how to setup a local version of the website and make sure the website is built correctly.

In addition, please fill out the following to help reviewers understand this pull request:

Description

Updated the steps to run hello world sample with Access control list in self hosted mode.

#851

_Please reference the issue this PR will close: #851

@vinayada1 vinayada1 requested review from msfussell and yaron2 December 9, 2020 22:37
Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I'm wondering if we should remove the pythonapp / nodeapp specific bits, as this is not a quickstart...

@vinayada1
Copy link
Contributor Author

Looks good overall, I'm wondering if we should remove the pythonapp / nodeapp specific bits, as this is not a quickstart...

However, this is in context of running the hello-world sample. I updated some links to point to this.

@msfussell
Copy link
Member

Did quite a bit of re-writing and restructuring of the docs. Please read this through. It is important that our instructions work for both Linux/MacOs and Windows and so you need to provide env configuration settings for Windows also. Hopefully the cert file exported by Sentry can be reference with these env variables will work for Windows also. Can you test this out?

You will see in the doc, tab headings for Linux/MacOS/Windows as in the example here https://docs.dapr.io/getting-started/install-dapr-cli/

I also structured this so there were example config files at the start and these were then used both locally and K8s, rather than having these all bundles under the K8s examples.

Note for future doc guidelines.

  1. References to other docs are now in the Hugo format like this [Init Dapr locally]({{< ref install-dapr.md >}})
  2. Stay away from "we" usage, since this is unclear who/what this is referring to. Stick to you, wherever possible. https://docs.dapr.io/contributing/contributing-docs/#style-and-tone

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the mTLS configuration doc to describe how to run Sentry control plan service locally
4 participants