Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing kafka pubsub properties #4415

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

passuied
Copy link
Contributor

@passuied passuied commented Nov 1, 2024

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add missing documentation for Kafka pubsub properties

Issue reference

#4414

@passuied passuied requested review from a team as code owners November 1, 2024 02:20
@hhunter-ms
Copy link
Collaborator

@passuied thank you for adding these! Could you also add to the yaml example above the spec metadata table?

@passuied
Copy link
Contributor Author

passuied commented Nov 4, 2024

@passuied thank you for adding these! Could you also add to the yaml example above the spec metadata table?

Added examples @hhunter-ms

@hhunter-ms hhunter-ms merged commit ef4d3ee into dapr:v1.14 Nov 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants