Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worflow examples for java #3865

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Conversation

kaibocai
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR fixes the incorrect workflow Java example.

Issue reference

Resolve #3864

@kaibocai kaibocai requested review from a team as code owners November 13, 2023 01:42
@kaibocai
Copy link
Contributor Author

Tag @cgillum , @johnewart , @cicoyle , @hhunter-ms for review.

Copy link
Contributor

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these great improvements! Just one nit-pick about naming to help make things a bit clearer and more consistent.

String wfInput = ctx.getInput(String.class);
String result1 = ctx.callActivity("event1", wfInput, String.class).await();
String result2 = ctx.callActivity("event2", result1, String.class).await();
String result3 = ctx.callActivity("event3", result2, String.class).await();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call these Step, Step2, and Step3, like we do with the other examples.

Signed-off-by: kaibocai <[email protected]>
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

@kaibocai
Copy link
Contributor Author

@hhunter-ms , can you please help me merge this pr as I don't have permission to do it myself. Thank you.

@hhunter-ms
Copy link
Collaborator

can you please help me merge this pr as I don't have permission to do it myself. Thank you.

@kaibocai needed to fix some links first, will merge once it builds successfully!

@hhunter-ms hhunter-ms merged commit 4f0c2d1 into dapr:v1.12 Nov 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow examples are wrong for Java
3 participants