-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix worflow examples for java #3865
Conversation
Signed-off-by: kaibocai <[email protected]>
Tag @cgillum , @johnewart , @cicoyle , @hhunter-ms for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these great improvements! Just one nit-pick about naming to help make things a bit clearer and more consistent.
String wfInput = ctx.getInput(String.class); | ||
String result1 = ctx.callActivity("event1", wfInput, String.class).await(); | ||
String result2 = ctx.callActivity("event2", result1, String.class).await(); | ||
String result3 = ctx.callActivity("event3", result2, String.class).await(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call these Step
, Step2
, and Step3
, like we do with the other examples.
Signed-off-by: kaibocai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution!
@hhunter-ms , can you please help me merge this pr as I don't have permission to do it myself. Thank you. |
@kaibocai needed to fix some links first, will merge once it builds successfully! |
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This PR fixes the incorrect workflow Java example.
Issue reference
Resolve #3864