Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deficiencies in the steps updated with the multi-app run feature that comes with v12 #3861

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

baransonmez
Copy link
Contributor

@baransonmez baransonmez commented Nov 8, 2023

Description

As mentioned in the Issue #3860 , there were deficiencies in the steps of the newly added multi-app run feature. Generally, the step of installing dependencies in the state-management header was skipped. In this PR, I added this step to the relevant points.

In addition, I made an extra note for the python3 problem in windows environments and informed the developers who will follow the document.

Issue reference

#3860

… the quickstart tutorial document. Add note for python3 problem in Windows environments.

Signed-off-by: İhsan Baran SÖNMEZ <[email protected]>
@hhunter-ms
Copy link
Collaborator

hhunter-ms commented Nov 13, 2023

FYI @mukundansundar - need to merge dapr/quickstarts#955 first

Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Nov 19, 2023
@msfussell msfussell removed the stale label Nov 22, 2023
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Nov 30, 2023
@baransonmez
Copy link
Contributor Author

Hello again, I completed the issue a few weeks ago but I am not aware if there is any extra work I need to do. Is there a point I missed? When I looked at the Github Actions, I understood that it's just waiting for the reviewer to check it, but I still wanted to ask to be sure.

@hhunter-ms
Copy link
Collaborator

@baransonmez sorry about the delay, I'm working on getting the code PR in the quickstart repo to go through

@baransonmez
Copy link
Contributor Author

Oh, I see. Well, if there's anything I can do, I'd like to help. Thank you for your quick response and interest @hhunter-ms

@github-actions github-actions bot removed the stale label Dec 1, 2023
Copy link

github-actions bot commented Dec 7, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 7, 2023
@yaron2 yaron2 added this to the 1.13 milestone Dec 7, 2023
@baransonmez
Copy link
Contributor Author

I merged 'v1.12' into this branch, do I need to do anything for the workflow to progress?

@github-actions github-actions bot removed the stale label Dec 9, 2023
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 15, 2023
@hhunter-ms hhunter-ms merged commit 1007192 into dapr:v1.12 Dec 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants