DAOS-10431 build: add ubuntu 22.04 client-only support #8811
Conversation
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-8811/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/1/execution/node/114/log |
|
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/1/execution/node/378/log |
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/1/execution/node/347/log |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/1/execution/node/375/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/1/execution/node/381/log |
|
Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/1/execution/node/397/log |
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
4ac373f to
04e6e8d
Compare
|
Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/1/execution/node/539/log |
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
04e6e8d to
5aa7712
Compare
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
|
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/3/execution/node/369/log |
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/3/execution/node/338/log |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/3/execution/node/381/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/3/execution/node/370/log |
|
Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/3/execution/node/412/log |
|
Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/3/execution/node/397/log |
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
5aa7712 to
03a2e3e
Compare
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/4/execution/node/337/log |
|
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/4/execution/node/380/log |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/4/execution/node/369/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/4/execution/node/366/log |
|
Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/4/execution/node/411/log |
|
Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/4/execution/node/396/log |
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
03a2e3e to
70a4b34
Compare
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
eb062f6 to
b1bc3c9
Compare
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/14/execution/node/347/log |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/14/execution/node/373/log |
|
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/14/execution/node/381/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/14/execution/node/374/log |
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
b1bc3c9 to
3386ab9
Compare
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-8811/15/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
FYI: Errors found in lines not modified in the patch:
src/tests/security/SConscript:4:
(pylint-missing-function-docstring) Missing function or method docstring
src/tests/security/SConscript:10:
(pylint-pointless-string-statement) String statement has no effect
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
| @@ -2,6 +2,11 @@ | |||
| import daos_build | |||
|
|
|||
| def scons(): | |||
| if not prereqs.server_requested(): | |||
There was a problem hiding this comment.
(pylint-used-before-assignment) Using variable 'prereqs' before assignment
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/15/execution/node/134/log |
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/15/execution/node/348/log |
|
Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/15/execution/node/429/log |
|
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/15/execution/node/410/log |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/15/execution/node/413/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/15/execution/node/407/log |
|
Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/15/execution/node/562/log |
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
3386ab9 to
e17438b
Compare
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
src/tests/security/SConscript:6:
(pylint-syntax-error) unindent does not match any outer indentation level (, line 13)
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/16/execution/node/328/log |
|
Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/16/execution/node/427/log |
This patch migrates Ubuntu support from 20.04 to 22.04 which is the latest LTS. It also removes support for server-side packages since Ubuntu support will be limited to the DAOS client going forward. GHA is also being updated to use 22.04. To support client-only build, a few extra changes were required: - Argobots should not be built/required for client-only build - Header files in the object module needed to be split between server (srv_internal.h) and client (obj_internal.h). - The enumeration code in the object module turns out to use server-side routines. The code has thus been split into two file: srv_enum.c (server-specific) and obj_enum.c (generic). Some server-side code used between server components has been exported by adding a new daos_srv/object.h header file. - The SConscript of the security module has a caching capability that breaks the client-only build. Signed-off-by: Johann Lombardi <[email protected]>
johannlombardi
force-pushed
the
ubuntu_2204
branch
from
e17438b to
b650888
Compare
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
site_scons/prereq_tools/base.py:312:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
site_scons/prereq_tools/base.py:63:
(pylint-consider-using-with) Consider using 'with' for resource-allocating operations
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/17/execution/node/347/log |
|
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/17/execution/node/381/log |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/17/execution/node/375/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8811/17/execution/node/359/log |
| @@ -16,11 +16,19 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
This patch migrates Ubuntu support from 20.04 to 22.04 which is the
latest LTS. It also removes support for server-side packages since
Ubuntu support will be limited to the DAOS client going forward.
GHA is also being updated to use 22.04.
To support client-only build, a few extra changes were required:
server and client.
server-side routines. The code has thus been split into two
file: srv_enum.c (server-specific) and obj_enum.c (generic).
that breaks the client-only build.
Signed-off-by: Johann Lombardi [email protected]