Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] DAOS-4093 test: java package and Java IT test. #4410

Draft
wants to merge 110 commits into
base: master
Choose a base branch
from

Conversation

saurabhtandan
Copy link
Contributor

Adding daos-tests-java package and enabling java IT test in CI.

Skip-func-test-vm: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration,small,hw

Signed-off-by: Saurabh Tandan [email protected]

Puspalogan and others added 30 commits August 20, 2020 19:47
  - Created new test ci_integration to run the java
    integration tests using mvn command.

Signed-off-by: Logan Sundaram <[email protected]>
Adding test to destroy pool during rebuild is on going
with io.

Signed-off-by: Saurabh Tandan <[email protected]>
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration

Signed-off-by: Saurabh Tandan <[email protected]>
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration
Skip-func-test-vm: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration

Signed-off-by: Saurabh Tandan <[email protected]>
Added -Ddaos.install.path option for maven command

Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration

Signed-off-by: Saurabh Tandan <[email protected]>
Collecting maven output.

Skip-func-test-vm: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration

Signed-off-by: Saurabh Tandan <[email protected]>
Skip-func-test-vm: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration

Signed-off-by: Saurabh Tandan <[email protected]>
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Test-tag-hw-small: javaciintegration

Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/40/execution/node/219/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/40/execution/node/237/log

Test-tag: javaciintegration
Quick-Functional: true

Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/41/execution/node/234/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/41/execution/node/237/log

Test-tag: javaciintegration
Quick-Functional: true

Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/42/execution/node/237/log

Test-tag: javaciintegration
Quick-Functional: true

Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/43/execution/node/236/log

Conflicts:
	Jenkinsfile
	src/tests/ftest/util/general_utils.py
	utils/rpms/daos.spec
Test-tag: javaciintegration
Quick-Functional: true

Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/44/execution/node/242/log

Test-tag: javaciintegration
Quick-Functional: true

Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/45/execution/node/239/log

Test-tag: javaciintegration
Quick-Functional: true
Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/46/execution/node/224/log

Test-tag: javaciintegration
Quick-Functional: true

Signed-off-by: Saurabh Tandan <[email protected]>
Test-tag: javaciintegration
Quick-Functional: true

Signed-off-by: Saurabh Tandan <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/48/execution/node/243/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/48/execution/node/225/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/48/execution/node/513/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/49/execution/node/242/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/49/execution/node/510/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4410/50/execution/node/242/log

Conflicts:
	utils/rpms/daos.spec

Skip-build: true
@daosbuild1 daosbuild1 dismissed their stale review April 24, 2021 00:46

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4410/51/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/client/java/daos-java/find_build_paths.sh:16:
(lint) Can't follow non-constant source. Use a directive to specify location. [SC1090]

@@ -2,14 +2,15 @@

daos_install_path=$1
var=$2
build_vars=../../../../.build_vars.sh
in_tree=$3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lint) in_tree appears unused. Verify use (or export if used externally). [SC2034]

@@ -44,4 +44,4 @@ else
echo "Unable to update /etc/mock/$CHROOT_NAME.cfg."
echo "You need to make sure it has the needed repos in it yourself."
fi
eval mock -r "$CHROOT_NAME" $MOCK_OPTIONS $RPM_BUILD_OPTIONS "$TARGET"
eval mock --enable-network -r "$CHROOT_NAME" $MOCK_OPTIONS $RPM_BUILD_OPTIONS "$TARGET"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lint) Double quote to prevent globbing and word splitting. [SC2086]
(lint) Double quote to prevent globbing and word splitting. [SC2086]

from general_utils import error_count
from java_utils import JavaUtils

class JavaCIIntegration(JavaUtils):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pylint-too-many-ancestors) Too many ancestors (8/7)

results = run_pcmd(hostlist, command, False, None, None)
for result in results:
for line in result["stdout"]:
if 'ERR' in line:
if pattern is not "ERR":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pylint-literal-comparison) Comparison to literal

self.log.info(result["stdout"])
self.fail("Failed to run cmd {} on {}".\
format(cmd, result["hosts"]))
if result["stdout"]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pylint-undefined-loop-variable) Using possibly undefined loop variable 'result'

self.fail("Failed to run cmd {} on {}".\
format(cmd, result["hosts"]))
if result["stdout"]:
return str(result["stdout"][0])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pylint-undefined-loop-variable) Using possibly undefined loop variable 'result'

command = [u"source {}/daos-java/find_java_home.sh".format(self.jdir)]
return self.run_command(self.hostlist_clients, command)

def run_command(self, hosts, commands, verbose=True, timeout=60):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pylint-inconsistent-return-statements) Either all return statements in a function should return an expression, or none of them should.

@daosbuild1
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants