DAOS-16834 test: tags.py config option #15983

phender · 2025-02-26T15:43:13Z

Add config command line option to tags.py to list test yaml data.

Test-tag: always_passes
Skip-unit-tests: true
Skip-fault-injection-test: true

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

Add support in tags.py to dump tests associated with tags and/or paths. Add TagSet to handle negative matching. E.g. foo,-bar Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>

Add data command line option to tags.py to list test yaml data. Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

github-actions · 2025-02-26T15:43:31Z

Ticket title is 'Support running existing tests in MD on SSD stages with two pool variants'
Status is 'In Progress'
Labels: 'md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-16834

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

src/tests/ftest/tags.py

daltonbohning · 2025-02-26T18:52:51Z

src/tests/ftest/tags.py

+    elif "weekly_regression" in tags:
+        return "weekly"
+    return "manual"


Probably should check if manual is in tags first so this function doesn't make unnecessary assumptions

Fixed, thanks.

src/tests/ftest/tags.py

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

daltonbohning · 2025-02-27T15:23:03Z

src/tests/ftest/tags.py

+        "-v", "--verbose",
+        action='store_true',
+        help="print verbose output")
+
    args = parser.parse_args()
    args.paths = list(map(os.path.realpath, args.paths))


This doesn't work now with the subparsers that don't have paths. E.g.

./src/tests/ftest/tags.py unit Traceback (most recent call last): File "/home/dbohning/daos-stack/daos/./src/tests/ftest/tags.py", line 959, in <module> sys.exit(main()) File "/home/dbohning/daos-stack/daos/./src/tests/ftest/tags.py", line 933, in main args.paths = list(map(os.path.realpath, args.paths)) AttributeError: 'Namespace' object has no attribute 'paths'

Ah, right. I meant to make that conditional.

src/tests/ftest/tags.py

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

daltonbohning · 2025-02-27T20:13:23Z

You'll want to merge in master now that mine is merged

Test-tag: test_always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

daltonbohning · 2025-02-27T22:42:29Z

src/tests/ftest/tags.py

+        Returns:
+            list: values found for the key
+        """
+        search = [[self.__data, ["root"]]]


What is "root" for?

daltonbohning · 2025-02-27T22:45:35Z

src/tests/ftest/tags.py

+    else:
+        raise ValueError(f"Unhandled command option: {args.command}")


I get this

./tags.py Traceback (most recent call last): File "/home/dbohning/daos-stack/daos/src/tests/ftest/./tags.py", line 960, in <module> sys.exit(main()) File "/home/dbohning/daos-stack/daos/src/tests/ftest/./tags.py", line 954, in main raise ValueError(f"Unhandled command option: {args.command}") ValueError: Unhandled command option: None

Fixed by making subparser 'command' required.

daltonbohning · 2025-02-27T22:47:56Z

src/tests/ftest/tags.py

+    subparsers = parser.add_subparsers(
+        title='options for the tags command',
+        dest='command')


We need required=True since it is required

Yes, thanks.

shimizukko · 2025-02-28T04:38:26Z

src/tests/ftest/tags.py

+    Args:
+        paths (list, optional): paths to files from which to list via their tags. Defaults to all
+            ftest python files.
+        list (set, optional): list of sets of tags used to filter displayed tests. Defaults to no


Suggested change

list (set, optional): list of sets of tags used to filter displayed tests. Defaults to no

tags (set, optional): list of sets of tags used to filter displayed tests. Defaults to no

Typo?

Yes, thanks.

shimizukko · 2025-02-28T04:38:41Z

src/tests/ftest/tags.py

+            ftest python files.
+        list (set, optional): list of sets of tags used to filter displayed tests. Defaults to no
+            filtering.
+        list (set, optional): list of sets of test yaml data keys to display. Defaults to None,


Suggested change

list (set, optional): list of sets of test yaml data keys to display. Defaults to None,

keys (set, optional): list of sets of test yaml data keys to display. Defaults to None,

Test-tag: test_always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

daltonbohning and others added 7 commits January 8, 2025 22:53

Merge remote-tracking branch 'origin/master' into dbohning/daos-15630

73111fa

optimization

5db8f1f

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>

handle incompatible args

b9ebf4e

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>

lint fix

363fd18

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>

optimize

20436af

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>

DAOS-16834 test: tags.py data option

209d698

Add data command line option to tags.py to list test yaml data. Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

phender requested review from a team as code owners February 26, 2025 15:43

Fix lint.

68a6c0f

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

daltonbohning reviewed Feb 26, 2025

View reviewed changes

phender added 3 commits February 26, 2025 14:27

Replace import from util.

f38f5e1

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

Apply feedback.

c2f155a

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

Mised one.

72bbe71

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

phender requested a review from daltonbohning February 26, 2025 21:24

Fix test_frequency.

9fb0f2c

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

daltonbohning reviewed Feb 27, 2025

View reviewed changes

Fix --paths handling.

42e9bfb

Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

Base automatically changed from dbohning/daos-15630 to master February 27, 2025 19:18

phender requested a review from daltonbohning February 27, 2025 19:44

phender changed the title ~~DAOS-16834 test: tags.py data option~~ DAOS-16834 test: tags.py config option Feb 27, 2025

Merge branch 'master' into hendersp/tags-data

561a389

Test-tag: test_always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

phender requested a review from shimizukko February 27, 2025 22:25

daltonbohning reviewed Feb 27, 2025

View reviewed changes

shimizukko previously approved these changes Feb 28, 2025

View reviewed changes

Support paths in config search.

0790b5e

Test-tag: test_always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

phender dismissed shimizukko’s stale review via 0790b5e March 1, 2025 05:25

phender requested a review from shimizukko March 1, 2025 05:26

phender requested a review from daltonbohning March 1, 2025 05:26

shimizukko approved these changes Mar 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-16834 test: tags.py config option #15983

DAOS-16834 test: tags.py config option #15983

phender commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025

daltonbohning Feb 26, 2025

phender Feb 27, 2025

daltonbohning Feb 27, 2025

phender Feb 27, 2025

daltonbohning commented Feb 27, 2025

daltonbohning Feb 27, 2025

daltonbohning Feb 27, 2025

phender Mar 1, 2025

daltonbohning Feb 27, 2025

phender Feb 28, 2025

shimizukko Feb 28, 2025

phender Mar 1, 2025

shimizukko Feb 28, 2025

phender Mar 1, 2025

		else:
		raise ValueError(f"Unhandled command option: {args.command}")

	list (set, optional): list of sets of tags used to filter displayed tests. Defaults to no
	tags (set, optional): list of sets of tags used to filter displayed tests. Defaults to no

	list (set, optional): list of sets of test yaml data keys to display. Defaults to None,
	keys (set, optional): list of sets of test yaml data keys to display. Defaults to None,

DAOS-16834 test: tags.py config option #15983

Are you sure you want to change the base?

DAOS-16834 test: tags.py config option #15983

Conversation

phender commented Feb 26, 2025 • edited Loading

Steps for the author:

After all prior steps are complete:

github-actions bot commented Feb 26, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daltonbohning commented Feb 27, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phender commented Feb 26, 2025 •

edited

Loading