Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16936 dtx: rank range based DTX hints for coll_punch - b26 #15975

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from

Conversation

Nasf-Fan
Copy link
Contributor

When handle collective punch RPC, the leader will generate hints array for related DTX RPC (abort or commit). Each involved engine will have one element in such array. To simplify RPC logic, such hints array is sparse and indexed with engine's rank#. Originally, we did not properly handled the case of incontinuous rank# in the pool map, as to when update some hints element with large rank#, the write maybe out of boundary and crash the others' space and cause kinds of DRAM corruption.

Similar situation can happen during handle collective DTX resync and cleanup.

This patch fixes such issue via building such sparse hints array based on related engines' rank# range instead of the ranks count in the pool map. Use relative ranks diff (real rank# - base rank#) as the index. That will avoid out of boundary access.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Feb 25, 2025

Ticket title is 'Aurora: assertion with collective punch running mdtest with 2048 ECBS'
Status is 'In Review'
Labels: 'ALCF,alcf_track,post_acceptance_issues,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16936

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15975/1/execution/node/1420/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16936_1_b26 branch 2 times, most recently from 46bcbbf to e290b80 Compare February 26, 2025 05:19
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15975/3/execution/node/1421/log

@Nasf-Fan
Copy link
Contributor Author

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15975/3/execution/node/1421/log

Failed for DAOS-17161.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review February 27, 2025 08:39
@Nasf-Fan Nasf-Fan requested review from a team as code owners February 27, 2025 08:39
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16936_1_b26 branch from e290b80 to f5d0049 Compare February 28, 2025 03:02
When handle collective punch RPC, the leader will generate hints
array for related DTX RPC (abort or commit). Each involved engine
will have one element in such array. To simplify RPC logic, such
hints array is sparse and indexed with engine's rank#. Originally,
we did not properly handled the case of incontinuous rank# in the
pool map, as to when update some hints element with large rank#,
the write maybe out of boundary and crash the others' space and
cause kinds of DRAM corruption.

Similar situation can happen during handle collective DTX resync
and cleanup.

This patch fixes such issue via building such sparse hints array
based on related engines' rank# range instead of the ranks count
in the pool map. Use relative ranks diff (real rank# - base rank#)
as the index. That will avoid out of boundary access.

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16936_1_b26 branch from f5d0049 to 3374803 Compare February 28, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants