-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-17151 engine: RPC credits for IO chore task #15970
base: master
Are you sure you want to change the base?
Conversation
Ticket title is 'ENOMEM on punch when running mdtest with RF2' |
12adc6d
to
fcee161
Compare
Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15970/3/testReport/ |
bb26d10
to
d3517d9
Compare
We need to control the in-flight RPCs (via IO chore tasks) count from current target to others. Otherwise, too many in-flight RPCs may occupy a lot of DRAM as to cause out of memory on server. Introduce new server-side environment DAOS_IO_CHORE_CREDITS to allow admin to configure such credits. The default value is 4096, it may be optimized in the future based on more test results. Allow-unstable-test: true Signed-off-by: Fan Yong <[email protected]>
d3517d9
to
2c462eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ftest LGTM
FYI clang-format is required now |
Hm... it seems that some required format changes is not related with my patch. For example: diff --git a/src/include/daos_fs.h b/src/include/daos_fs.h But my patch has never touched such file. On the other hand, the clang-format requirement for different function clarifications are not consistent, for example: -int dss_chore_register(struct dss_chore *chore);
So do you think we have to pass clang-format check currently? @daltonbohning @gnailzenh |
Signed-off-by: Fan Yong <[email protected]>
Signed-off-by: Fan Yong <[email protected]>
We need to control the in-flight RPCs (via IO chore tasks) count from current target to others. Otherwise, too many in-flight RPCs may occupy a lot of DRAM as to cause out of memory on server.
Introduce new server-side environment DAOS_IO_CHORE_CREDITS to allow admin to configure such credits. The default value is 4096, it may be optimized in the future based on more test results.
Allow-unstable-test: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: