Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17151 engine: RPC credits for IO chore task - b26 #15961

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Feb 24, 2025

We need to control the in-flight RPCs (via IO chore tasks) count from current target to others. Otherwise, too many in-flight RPCs may occupy a lot of DRAM as to cause out of memory on server.

Introduce new server-side environment DAOS_IO_CHORE_CREDITS to allow admin to configure such credits. The default value is 4096, it may be optimized in the future based on more test results.

Allow-unstable-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Feb 24, 2025

Ticket title is 'ENOMEM on punch when running mdtest with RF2'
Status is 'In Review'
Labels: 'ALCF,alcf_track'
https://daosio.atlassian.net/browse/DAOS-17151

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-17151_t1_b26 branch from 89fcbf3 to e7cdd59 Compare February 24, 2025 06:49
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15961/2/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-17151_t1_b26 branch from e7cdd59 to 8b0c80e Compare February 24, 2025 10:18
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15961/3/execution/node/1421/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-17151_t1_b26 branch 2 times, most recently from 5fe96dd to 032dc3f Compare February 25, 2025 08:52
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15961/5/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-17151_t1_b26 branch 3 times, most recently from a810410 to 3dee05c Compare February 25, 2025 16:07
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15961/8/execution/node/1421/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-17151_t1_b26 branch from 3dee05c to 78b746e Compare February 26, 2025 01:52
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15961/10/execution/node/1499/log

@Nasf-Fan
Copy link
Contributor Author

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15961/10/execution/node/1499/log

Hit a lot of assertion because of DAOS-17094. Have to be retested.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15961/11/execution/node/1510/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-17151_t1_b26 branch from 78b746e to 61fd65b Compare February 27, 2025 04:53
We need to control the in-flight RPCs (via IO chore tasks) count from current
target to others. Otherwise, too many in-flight RPCs may occupy a lot of DRAM
as to cause out of memory on server.

Introduce new server-side environment DAOS_IO_CHORE_CREDITS to allow admin to
configure such credits. The default value is 4096, it may be optimized in the
future based on more test results.

Allow-unstable-test: true

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-17151_t1_b26 branch from 61fd65b to 85f95e6 Compare February 27, 2025 05:00
@Nasf-Fan Nasf-Fan marked this pull request as ready for review February 28, 2025 01:14
@Nasf-Fan Nasf-Fan requested review from a team as code owners February 28, 2025 01:14
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants