-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16620 vos: exit scrub earlier during container destruction #15957
Open
wangshilong
wants to merge
6
commits into
master
Choose a base branch
from
shilongw/DAOS-16620
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−0
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
38c35c5
DAOS-16620 vos: Exit scrub earlier during container destruction
wangshilong 3258ac9
address comments
wangshilong e22f090
Merge branch 'master' of github.com:daos-stack/daos into shilongw/DAO…
wangshilong 97b3557
test tag
wangshilong d090ef5
Merge branch 'master' of github.com:daos-stack/daos into shilongw/DAO…
wangshilong 9631f72
address comments
wangshilong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -272,31 +272,45 @@ sc_get_rec_in_chunk_at_idx(const struct scrub_ctx *ctx, uint32_t i) | |
static void | ||
sc_wait_until_should_continue(struct scrub_ctx *ctx) | ||
{ | ||
if (sc_cont_is_stopping(ctx)) | ||
return; | ||
|
||
if (sc_mode(ctx) == DAOS_SCRUB_MODE_TIMED) { | ||
struct timespec now; | ||
uint64_t msec_between; | ||
|
||
d_gettime(&now); | ||
while ((msec_between = sc_get_ms_between_scrubs(ctx)) > 0) { | ||
d_tm_set_gauge(ctx->sc_metrics.scm_next_csum_scrub, msec_between); | ||
if (sc_cont_is_stopping(ctx)) | ||
break; | ||
/* don't wait longer than 1 sec each loop */ | ||
sc_sleep(ctx, min(1000, msec_between)); | ||
} | ||
} else if (sc_mode(ctx) == DAOS_SCRUB_MODE_LAZY) { | ||
sc_sleep(ctx, 0); | ||
while (!sc_is_idle(ctx) && sc_mode(ctx) == DAOS_SCRUB_MODE_LAZY) { | ||
sc_m_track_busy(ctx); | ||
if (sc_cont_is_stopping(ctx)) | ||
break; | ||
/* Don't actually know how long it will be but wait for 1 second before | ||
* trying again | ||
*/ | ||
sc_sleep(ctx, 1000); | ||
} | ||
sc_m_track_idle(ctx); | ||
} else { | ||
uint64_t sleep_seconds = 300; | ||
|
||
D_ERROR("Unknown Scrub Mode: %d, Pool: " DF_UUID "\n", sc_mode(ctx), | ||
DP_UUID(ctx->sc_pool->sp_uuid)); | ||
/* sleep for 5 minutes to give pool property chance to resolve */ | ||
sc_sleep(ctx, 1000 * 60 * 5); | ||
while (sleep_seconds > 0) { | ||
if (sc_cont_is_stopping(ctx)) | ||
break; | ||
sc_sleep(ctx, 1000); | ||
sleep_seconds--; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sched_req_wakeup(cont->sc_pool->spc_scrubbing_req) is called on VOS container destroy, this is not necessary. |
||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly, checking stopping before d_tm_set_gauge() or after sc_sleep() seems better. Anyway, not serious, can be adjusted latter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. fixed.